Bug 1053898 - Use dataset.event to easily find event listener for event bubble draft
authorJulian Descottes <jdescottes@mozilla.com>
Mon, 05 Feb 2018 17:08:58 +0100
changeset 764200 f38e808f8b0b6e18551db61c0ebe8550030e1534
parent 764199 dde04fa94fb218ef9399b5a5c43120da10534be0
child 764201 38e6519e250feb3ef7619ae2ff18fe3dd54eee0e
push id101700
push userjdescottes@mozilla.com
push dateWed, 07 Mar 2018 12:25:23 +0000
bugs1053898
milestone60.0a1
Bug 1053898 - Use dataset.event to easily find event listener for event bubble MozReview-Commit-ID: 3VEcGsG9oS1
devtools/client/inspector/markup/views/element-container.js
--- a/devtools/client/inspector/markup/views/element-container.js
+++ b/devtools/client/inspector/markup/views/element-container.js
@@ -41,17 +41,17 @@ function MarkupElementContainer(markupVi
     throw new Error("Invalid node for MarkupElementContainer");
   }
 
   this.tagLine.appendChild(this.editor.elt);
 }
 
 MarkupElementContainer.prototype = extend(MarkupContainer.prototype, {
   _buildEventTooltipContent: Task.async(function* (target, tooltip) {
-    if (target.hasAttribute("data-event")) {
+    if (target.dataset.event) {
       yield tooltip.hide();
 
       let listenerInfo = yield this.node.getEventListenerInfo();
 
       let toolbox = this.markup.toolbox;
 
       setEventTooltip(tooltip, listenerInfo, toolbox);
       // Disable the image preview tooltip while we display the event details