Bug 1435618: Don't leak a reference to the gfx info. r?kats draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sun, 04 Feb 2018 17:40:40 +0100
changeset 751030 096c65cf1db4bf75f6e79e9cb33103ae793064b0
parent 751028 7092bad35191e5c0e452503eb4463a85e9553c0c
child 751039 b209d003309cdcbfe8d7fef41d47472b309e2347
child 751040 1dfea5c642753a78c30e0e042657575f8e5ae009
push id97821
push userbmo:emilio@crisal.io
push dateSun, 04 Feb 2018 16:45:08 +0000
reviewerskats
bugs1435618
milestone60.0a1
Bug 1435618: Don't leak a reference to the gfx info. r?kats GetGfxInfo returns an already_AddRefed, you can't just forget about its return value. MozReview-Commit-ID: Ia6pyJN9njf
gfx/ipc/GPUParent.cpp
--- a/gfx/ipc/GPUParent.cpp
+++ b/gfx/ipc/GPUParent.cpp
@@ -187,17 +187,19 @@ GPUParent::RecvInit(nsTArray<GfxPrefSett
   }
 
 #if defined(XP_WIN)
   if (gfxConfig::IsEnabled(Feature::D3D11_COMPOSITING)) {
     DeviceManagerDx::Get()->CreateCompositorDevices();
   }
   if (gfxVars::UseWebRender()) {
     // Ensure to initialize GfxInfo
-    services::GetGfxInfo();
+    nsCOMPtr<nsIGfxInfo> gfxInfo = services::GetGfxInfo();
+    Unused << gfxInfo;
+
     Factory::EnsureDWriteFactory();
   }
 #endif
 
 #if defined(MOZ_WIDGET_GTK)
   char* display_name = PR_GetEnv("DISPLAY");
   if (display_name) {
     int argc = 3;