Bug 1421837 - Remove list{item|cell}-checkbox-iconic binding. r=Paolo draft
authorTimothy Guan-tin Chien <timdream@gmail.com>
Fri, 02 Feb 2018 23:04:12 +0800
changeset 751068 548f87144ac82f98ca5f20d5be0015398806bf63
parent 751044 ef1fefe4c6d1f95e2bdf872094e02e85c962aa86
push id97836
push usertimdream@gmail.com
push dateMon, 05 Feb 2018 05:04:26 +0000
reviewersPaolo
bugs1421837
milestone60.0a1
Bug 1421837 - Remove list{item|cell}-checkbox-iconic binding. r=Paolo MozReview-Commit-ID: CcpvdPgU5yJ
toolkit/content/widgets/listbox.xml
toolkit/content/xul.css
--- a/toolkit/content/widgets/listbox.xml
+++ b/toolkit/content/widgets/listbox.xml
@@ -1108,25 +1108,16 @@
           this.checked = !this.checked;
           this.doCommand();
         }
       ]]>
       </handler>
     </handlers>
   </binding>
 
-  <binding id="listitem-checkbox-iconic"
-           extends="chrome://global/content/bindings/listbox.xml#listitem-checkbox">
-    <content>
-      <children>
-        <xul:listcell type="checkbox" class="listcell-iconic" xbl:inherits="label,image,crop,checked,disabled,flexlabel"/>
-      </children>
-    </content>
-  </binding>
-
   <binding id="listcell" role="xul:listcell"
            extends="chrome://global/content/bindings/general.xml#basecontrol">
 
     <resources>
       <stylesheet src="chrome://global/skin/listbox.css"/>
     </resources>
 
     <content>
@@ -1151,27 +1142,16 @@
     <content>
       <children>
         <xul:image class="listcell-check" xbl:inherits="checked,disabled"/>
         <xul:label class="listcell-label" xbl:inherits="value=label,flex=flexlabel,crop,disabled" flex="1" crop="right"/>
       </children>
     </content>
   </binding>
 
-  <binding id="listcell-checkbox-iconic"
-           extends="chrome://global/content/bindings/listbox.xml#listcell-checkbox">
-    <content>
-      <children>
-        <xul:image class="listcell-check" xbl:inherits="checked,disabled"/>
-        <xul:image class="listcell-icon" xbl:inherits="src=image"/>
-        <xul:label class="listcell-label" xbl:inherits="value=label,flex=flexlabel,crop,disabled" flex="1" crop="right"/>
-      </children>
-    </content>
-  </binding>
-
   <binding id="listhead" role="xul:listhead">
 
     <resources>
       <stylesheet src="chrome://global/skin/listbox.css"/>
     </resources>
 
     <content>
       <xul:listheaditem>
--- a/toolkit/content/xul.css
+++ b/toolkit/content/xul.css
@@ -566,28 +566,20 @@ listcell {
 listcell[type="checkbox"] {
   -moz-binding: url("chrome://global/content/bindings/listbox.xml#listcell-checkbox");
 }
 
 .listitem-iconic {
   -moz-binding: url("chrome://global/content/bindings/listbox.xml#listitem-iconic");
 }
 
-listitem[type="checkbox"].listitem-iconic {
-  -moz-binding: url("chrome://global/content/bindings/listbox.xml#listitem-checkbox-iconic");
-}
-
 .listcell-iconic {
   -moz-binding: url("chrome://global/content/bindings/listbox.xml#listcell-iconic");
 }
 
-listcell[type="checkbox"].listcell-iconic {
-  -moz-binding: url("chrome://global/content/bindings/listbox.xml#listcell-checkbox-iconic");
-}
-
 listbox {
   display: -moz-grid;
 }
 
 listbox[rows] {
   height: auto;
 }