Bug 1435248 - Drop unnecessary virtualization of function. r?nical draft
authorKartikaya Gupta <kgupta@mozilla.com>
Fri, 02 Feb 2018 08:57:35 -0500
changeset 750496 3906fdc26418fe5f6c9a06ef3965ef42b85e9e3a
parent 750495 e0faca86465070806d9816b89137f11bb46864e4
child 750497 2500b20d0e26fbcf883b9fb113d5ac30868d230a
push id97691
push userkgupta@mozilla.com
push dateFri, 02 Feb 2018 14:57:36 +0000
reviewersnical
bugs1435248
milestone60.0a1
Bug 1435248 - Drop unnecessary virtualization of function. r?nical This function is not overridden, so there doesn't seem to be any value in making it virtual. MozReview-Commit-ID: 8K34xTGtBc7
gfx/layers/ipc/CompositorBridgeParent.h
--- a/gfx/layers/ipc/CompositorBridgeParent.h
+++ b/gfx/layers/ipc/CompositorBridgeParent.h
@@ -288,17 +288,17 @@ public:
   void InvalidateOnCompositorThread();
   /**
    * Returns true if a surface was obtained and the resume succeeded; false
    * otherwise.
    */
   bool ScheduleResumeOnCompositorThread();
   bool ScheduleResumeOnCompositorThread(int width, int height);
 
-  virtual void ScheduleComposition();
+  void ScheduleComposition();
   void NotifyShadowTreeTransaction(uint64_t aId, bool aIsFirstPaint,
       const FocusTarget& aFocusTarget,
       bool aScheduleComposite, uint32_t aPaintSequenceNumber,
       bool aIsRepeatTransaction, bool aHitTestUpdate);
 
   void UpdatePaintTime(LayerTransactionParent* aLayerTree,
                        const TimeDuration& aPaintTime) override;