Bug 1310491 - Part 2 - Abort speculative download if user backs out of our App Chooser dialogue. r?esawin draft
authorJan Henning <jh+bugzilla@buttercookie.de>
Sat, 27 Jan 2018 13:34:23 +0100
changeset 748033 a26eef0f44d34aef2de0ca8295d192aff9226dc1
parent 748032 f991a48ee16b34fdf669b0b05e92e50423842b34
push id97050
push usermozilla@buttercookie.de
push dateSat, 27 Jan 2018 12:54:44 +0000
reviewersesawin
bugs1310491
milestone60.0a1
Bug 1310491 - Part 2 - Abort speculative download if user backs out of our App Chooser dialogue. r?esawin MozReview-Commit-ID: 1YsD2WZsats
mobile/android/components/HelperAppDialog.js
--- a/mobile/android/components/HelperAppDialog.js
+++ b/mobile/android/components/HelperAppDialog.js
@@ -221,16 +221,17 @@ HelperAppLauncherDialog.prototype = {
       buttons: [
         newButtonOrder ? alwaysUse : justOnce,
         newButtonOrder ? justOnce : alwaysUse
       ],
       // Tapping an app twice should choose "Just once".
       doubleTapButton: newButtonOrder ? 1 : 0
     }, (data) => {
       if (data.button < 0) {
+        aLauncher.cancel(Cr.NS_BINDING_ABORTED);
         return;
       }
 
       callback(apps[data.icongrid0]);
 
       if (data.button === (newButtonOrder ? 0 : 1)) {
         this._setPreferredApp(aLauncher, apps[data.icongrid0]);
       }