Bug 1432538 - Delete chrome viewport screen capture test. r?whimboo draft
authorAndreas Tolfsen <ato@sny.no>
Wed, 24 Jan 2018 15:00:46 +0000
changeset 724130 284435839a9b61e6a839b94b6b78428fc6b9c999
parent 724080 0e62eb7804c00c0996a9bdde5350328a384fb7af
child 747062 26d007c20bd9d92805c02dd06e4756d9dda84dfb
push id96655
push userbmo:ato@sny.no
push dateWed, 24 Jan 2018 15:08:19 +0000
reviewerswhimboo
bugs1432538
milestone60.0a1
Bug 1432538 - Delete chrome viewport screen capture test. r?whimboo Capturing the viewport of a ChromeWindow does not make sense because ChromeWindows do not normally have a scrollable area. test_capture_viewport loads an HTML document to "get scrollbars", but scrollbars and indeed HTML documents make no sense in ChromeWindows. The viewport is really only a concept in web content. As if this is not bad enough, when window.openDialog is called on a ChromeWindow Marionette also fails to load the content frame script. MozReview-Commit-ID: 7XXD45qIGim
testing/marionette/harness/marionette_harness/tests/unit/test_screenshot.py
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_screenshot.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_screenshot.py
@@ -202,34 +202,16 @@ class TestScreenCaptureChrome(WindowMana
 
         self.assert_png(screenshot_full)
         self.assert_png(screenshot_root)
         self.assertEqual(screenshot_root, screenshot_full)
         self.assertEqual(self.scale(self.get_element_dimensions(self.document_element)),
                          self.get_image_dimensions(screenshot_full))
 
     @skip_if_mobile("Fennec doesn't support other chrome windows")
-    def test_capture_viewport(self):
-        # Load a HTML test page into the chrome window to get scrollbars
-        test_page = self.marionette.absolute_url("test.html")
-        dialog = self.open_dialog(url=test_page, width=50, height=50)
-        self.marionette.switch_to_window(dialog)
-
-        # Size of screenshot has to match viewport size
-        screenshot = self.marionette.screenshot(full=False)
-        self.assert_png(screenshot)
-        self.assertEqual(self.scale(self.viewport_dimensions),
-                         self.get_image_dimensions(screenshot))
-        self.assertNotEqual(self.scale(self.window_dimensions),
-                            self.get_image_dimensions(screenshot))
-
-        self.marionette.close_chrome_window()
-        self.marionette.switch_to_window(self.start_window)
-
-    @skip_if_mobile("Fennec doesn't support other chrome windows")
     def test_capture_window_already_closed(self):
         dialog = self.open_dialog()
         self.marionette.switch_to_window(dialog)
         self.marionette.close_chrome_window()
 
         self.assertRaises(NoSuchWindowException, self.marionette.screenshot)
         self.marionette.switch_to_window(self.start_window)