Bug 1431947 - Remove the edge around the flex basis highlight. r=gl
authorZhenghong Qian <zhenghong.qian@mail.utoronto.ca>
Sat, 20 Jan 2018 15:18:30 -0500
changeset 722931 553f7f86829a479910782e82511c986be4f75dee
parent 722929 e1c079056de4d8b8ac7a34bf43f14aeeb287505e
child 722934 17c765608b0b495334a8763eee8a1d4e8a1d0fe0
child 722958 f4d39b4580a145dbeebac275f0edf93f7f69b07a
child 723646 9b46c508c390b0464d20b372eae8e975fa7a3fd6
push id96271
push userbmo:zhenghong.qian@mail.utoronto.ca
push dateSat, 20 Jan 2018 20:18:48 +0000
reviewersgl
bugs1431947
milestone59.0a1
Bug 1431947 - Remove the edge around the flex basis highlight. r=gl MozReview-Commit-ID: EnMtsAganyG
devtools/server/actors/highlighters/flexbox.js
--- a/devtools/server/actors/highlighters/flexbox.js
+++ b/devtools/server/actors/highlighters/flexbox.js
@@ -33,17 +33,16 @@ const FLEXBOX_LINES_PROPERTIES = {
     lineDash: [0, 0]
   }
 };
 
 const FLEXBOX_CONTAINER_PATTERN_WIDTH = 14; // px
 const FLEXBOX_CONTAINER_PATTERN_HEIGHT = 14; // px
 const FLEXBOX_CONTAINER_PATTERN_LINE_DISH = [5, 3]; // px
 const BASIS_FILL_COLOR = "rgb(109, 184, 255, 0.4)";
-const BASIS_EDGE_COLOR = "#6aabed";
 
 /**
  * Cached used by `FlexboxHighlighter.getFlexContainerPattern`.
  */
 const gCachedFlexboxPattern = new Map();
 
 const FLEXBOX = "flexbox";
 
@@ -318,19 +317,17 @@ class FlexboxHighlighter extends AutoRef
     if (basis.endsWith("px")) {
       right = left + parseFloat(basis);
     } else if (basis.endsWith("%")) {
       basis = parseFloat(basis) / 100 * boundsWidth;
       right = left + basis;
     }
 
     this.ctx.fillStyle = BASIS_FILL_COLOR;
-    this.ctx.strokeStyle = BASIS_EDGE_COLOR;
     drawRect(this.ctx, left, top, right, bottom, this.currentMatrix);
-    this.ctx.stroke();
     this.ctx.fill();
   }
 
   renderFlexItems() {
     if (!this.currentQuads.content || !this.currentQuads.content[0]) {
       return;
     }