Bug 1254242 Clean up React propType definitions draft
authortushararora <tushararora.cs@gmail.com>
Sat, 20 Jan 2018 15:41:14 +0530
changeset 722802 e93d95b62b744d24236744e8d0e66033c1649ab5
parent 722801 6bb6f3b25f9fe7ae1ef5092496776a891250cbb6
child 746708 b2657a733cb0541385e2796ff6f830d153b46f6b
push id96259
push userbmo:tushararora.cs@gmail.com
push dateSat, 20 Jan 2018 10:11:59 +0000
bugs1254242
milestone59.0a1
Bug 1254242 Clean up React propType definitions MozReview-Commit-ID: 2uicOuBXP0q
devtools/client/memory/components/Toolbar.js
--- a/devtools/client/memory/components/Toolbar.js
+++ b/devtools/client/memory/components/Toolbar.js
@@ -9,44 +9,34 @@ const PropTypes = require("devtools/clie
 const dom = require("devtools/client/shared/vendor/react-dom-factories");
 const { L10N } = require("../utils");
 const models = require("../models");
 const { viewState } = require("../constants");
 
 class Toolbar extends Component {
   static get propTypes() {
     return {
-      censusDisplays: PropTypes.arrayOf(PropTypes.shape({
-        displayName: PropTypes.string.isRequired,
-      })).isRequired,
-      censusDisplay: PropTypes.shape({
-        displayName: PropTypes.string.isRequired,
-      }).isRequired,
+      censusDisplays: PropTypes.arrayOf(models.censusDisplay).isRequired,
+      censusDisplay: models.censusDisplay,
       onTakeSnapshotClick: PropTypes.func.isRequired,
       onImportClick: PropTypes.func.isRequired,
       onClearSnapshotsClick: PropTypes.func.isRequired,
       onCensusDisplayChange: PropTypes.func.isRequired,
       onToggleRecordAllocationStacks: PropTypes.func.isRequired,
       allocations: models.allocations,
       filterString: PropTypes.string,
       setFilterString: PropTypes.func.isRequired,
       diffing: models.diffingModel,
       onToggleDiffing: PropTypes.func.isRequired,
       view: models.view.isRequired,
       onViewChange: PropTypes.func.isRequired,
-      labelDisplays: PropTypes.arrayOf(PropTypes.shape({
-        displayName: PropTypes.string.isRequired,
-      })).isRequired,
-      labelDisplay: PropTypes.shape({
-        displayName: PropTypes.string.isRequired,
-      }).isRequired,
+      labelDisplays: PropTypes.arrayOf(models.labelDisplay).isRequired,
+      labelDisplay: models.labelDisplay,
       onLabelDisplayChange: PropTypes.func.isRequired,
-      treeMapDisplays: PropTypes.arrayOf(PropTypes.shape({
-        displayName: PropTypes.string.isRequired,
-      })).isRequired,
+      treeMapDisplays: PropTypes.arrayOf(models.treeMapDisplay).isRequired,
       onTreeMapDisplayChange: PropTypes.func.isRequired,
       snapshots: PropTypes.arrayOf(models.snapshot).isRequired,
     };
   }
 
   render() {
     let {
       onTakeSnapshotClick,