Bug 1431522 - Remove the 'thumb' binding;r=enndeakin+6102 draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Fri, 19 Jan 2018 08:08:49 -0800
changeset 760503 e59cdfb24451dff45c8dcdd256ffc53ae504fb40
parent 760371 b184be59874080e96903183176c0f88dcbfafe25
push id100676
push userbgrinstead@mozilla.com
push dateTue, 27 Feb 2018 19:50:52 +0000
reviewersenndeakin
bugs1431522
milestone60.0a1
Bug 1431522 - Remove the 'thumb' binding;r=enndeakin+6102 MozReview-Commit-ID: JioZr8WAuPw
layout/base/nsCSSFrameConstructor.cpp
toolkit/content/minimal-xul.css
toolkit/content/widgets/scrollbar.xml
--- a/layout/base/nsCSSFrameConstructor.cpp
+++ b/layout/base/nsCSSFrameConstructor.cpp
@@ -4504,16 +4504,17 @@ nsCSSFrameConstructor::FindXULTagData(El
 {
   if (aNameSpaceID != kNameSpaceID_XUL) {
     return nullptr;
   }
 
   static const FrameConstructionDataByTag sXULTagData[] = {
 #ifdef MOZ_XUL
     SCROLLABLE_XUL_CREATE(button, NS_NewButtonBoxFrame),
+    SCROLLABLE_XUL_CREATE(thumb, NS_NewButtonBoxFrame),
     SCROLLABLE_XUL_CREATE(checkbox, NS_NewButtonBoxFrame),
     SCROLLABLE_XUL_CREATE(radio, NS_NewButtonBoxFrame),
     SCROLLABLE_XUL_CREATE(autorepeatbutton, NS_NewAutoRepeatBoxFrame),
     SCROLLABLE_XUL_CREATE(titlebar, NS_NewTitleBarFrame),
     SCROLLABLE_XUL_CREATE(resizer, NS_NewResizerFrame),
     SIMPLE_XUL_CREATE(image, NS_NewImageBoxFrame),
     SIMPLE_XUL_CREATE(spring, NS_NewLeafBoxFrame),
     SIMPLE_XUL_CREATE(spacer, NS_NewLeafBoxFrame),
--- a/toolkit/content/minimal-xul.css
+++ b/toolkit/content/minimal-xul.css
@@ -82,17 +82,16 @@ resizer {
 /********** scrollbar **********/
 
 /* Scrollbars are never flipped even if BiDI kicks in. */
 scrollbar[orient="horizontal"] {
   direction: ltr;
 }
 
 thumb {
-  -moz-binding: url(chrome://global/content/bindings/scrollbar.xml#thumb);
   display: -moz-box !important;
 }
 
 .scale-thumb {
   -moz-binding: url(chrome://global/content/bindings/scale.xml#scalethumb);
 }
 
 scrollbar, scrollbarbutton, scrollcorner, slider, thumb, scale {
--- a/toolkit/content/widgets/scrollbar.xml
+++ b/toolkit/content/widgets/scrollbar.xml
@@ -3,18 +3,16 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 
 <bindings id="scrollbarBindings"
    xmlns="http://www.mozilla.org/xbl"
    xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
    xmlns:xbl="http://www.mozilla.org/xbl">
-  
-  <binding id="thumb" extends="xul:button" />
 
   <binding id="scrollbar" bindToUntrustedContent="true">
     <content clickthrough="always">
       <xul:scrollbarbutton sbattr="scrollbar-up-top" type="decrement" xbl:inherits="curpos,maxpos,disabled,sborient=orient"/>
       <xul:scrollbarbutton sbattr="scrollbar-down-top" type="increment" xbl:inherits="curpos,maxpos,disabled,sborient=orient"/>
       <xul:slider flex="1" xbl:inherits="disabled,curpos,maxpos,pageincrement,increment,orient,sborient=orient">
         <xul:thumb sbattr="scrollbar-thumb" xbl:inherits="orient,sborient=orient,collapsed=disabled" 
                    align="center" pack="center"/>