Bug 1430707: Don't MOZ_CRASH when conduit operations fail. r?drno draft
authorByron Campen [:bwc] <docfaraday@gmail.com>
Fri, 19 Jan 2018 08:39:59 -0600 (2018-01-19)
changeset 722682 076e3f557fb13b81f5695dec2033ad3c0aa3124f
parent 721495 4e429d313fd2e0f9202271ee8f3fb798817ec3e7
child 746658 dd68d7f83e9cb2d96c01025b123f35209a3ac25e
push id96197
push userbcampen@mozilla.com
push dateFri, 19 Jan 2018 14:41:04 +0000 (2018-01-19)
reviewersdrno
bugs1430707
milestone59.0a1
Bug 1430707: Don't MOZ_CRASH when conduit operations fail. r?drno MozReview-Commit-ID: 32nYEJ3hht2
media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp
--- a/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp
+++ b/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp
@@ -482,24 +482,22 @@ PeerConnectionMedia::UpdateMediaPipeline
   // feasible to plumb error information all the way back. So, we set up a
   // handle to the PC (for the duration of this call) in a global variable.
   // This allows the GMP code to report errors to the PC.
   WebrtcGmpPCHandleSetter setter(mParentHandle);
 
   for (RefPtr<TransceiverImpl>& transceiver : mTransceivers) {
     nsresult rv = transceiver->UpdateConduit();
     if (NS_FAILED(rv)) {
-      MOZ_CRASH();
       return rv;
     }
 
     if (!transceiver->IsVideo()) {
       rv = transceiver->SyncWithMatchingVideoConduits(mTransceivers);
       if (NS_FAILED(rv)) {
-        MOZ_CRASH();
         return rv;
       }
       // TODO: If there is no audio, we should probably de-sync. However, this
       // has never been done before, and it is unclear whether it is safe...
     }
   }
 
   return NS_OK;