Bug 1430707: Don't MOZ_CRASH when conduit operations fail. r?drno
MozReview-Commit-ID: 32nYEJ3hht2
--- a/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp
+++ b/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp
@@ -482,24 +482,22 @@ PeerConnectionMedia::UpdateMediaPipeline
// feasible to plumb error information all the way back. So, we set up a
// handle to the PC (for the duration of this call) in a global variable.
// This allows the GMP code to report errors to the PC.
WebrtcGmpPCHandleSetter setter(mParentHandle);
for (RefPtr<TransceiverImpl>& transceiver : mTransceivers) {
nsresult rv = transceiver->UpdateConduit();
if (NS_FAILED(rv)) {
- MOZ_CRASH();
return rv;
}
if (!transceiver->IsVideo()) {
rv = transceiver->SyncWithMatchingVideoConduits(mTransceivers);
if (NS_FAILED(rv)) {
- MOZ_CRASH();
return rv;
}
// TODO: If there is no audio, we should probably de-sync. However, this
// has never been done before, and it is unclear whether it is safe...
}
}
return NS_OK;