Bug 1429056 - Don't strip llvm-dsymutil. r?build draft
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 19 Jan 2018 10:16:11 +0900
changeset 722590 9e9add85756c3dd6f87207c6ab73184e81007aea
parent 721979 1cf8104f7d6fcbbad2a4a6f0e899cace8268a75f
child 722591 52b94751859332f043eb5d4f8a0565561df7a644
push id96180
push userbmo:mh+mozilla@glandium.org
push dateFri, 19 Jan 2018 10:06:50 +0000
reviewersbuild
bugs1429056, 1430315
milestone59.0a1
Bug 1429056 - Don't strip llvm-dsymutil. r?build When I originally wrote the llvm-dsymutil build script in bug 1430315, I wasn't setting CMAKE_BUILD_TYPE to Release, and was ending up with a very large binary (> 300MB), so I stripped it. When I later set CMAKE_BUILD_TYPE to Release, I left the manual stripping on, but that removes symbols that are useful for stacktraces when dsymutil crashes (the Release type still leaves out debug info).
taskcluster/scripts/misc/build-llvm-dsymutil.sh
--- a/taskcluster/scripts/misc/build-llvm-dsymutil.sh
+++ b/taskcluster/scripts/misc/build-llvm-dsymutil.sh
@@ -25,14 +25,12 @@ cmake \
   -DLLVM_TARGETS_TO_BUILD=X86 \
   -DCMAKE_C_COMPILER=$HOME_DIR/src/gcc/bin/gcc \
   ..
 
 export LD_LIBRARY_PATH=$HOME_DIR/src/gcc/lib64
 
 ninja llvm-dsymutil
 
-strip bin/llvm-dsymutil
-
 tar --xform='s,^,llvm-dsymutil/,' -Jcf llvm-dsymutil.tar.xz bin/llvm-dsymutil
 
 mkdir -p $UPLOAD_DIR
 cp llvm-dsymutil.tar.xz $UPLOAD_DIR