Bug 1431449 - Make URLParams::DecodeString static; r?bz draft
authorAnthony Ramine <n.oxyde@gmail.com>
Thu, 18 Jan 2018 13:13:08 +0100
changeset 722189 3f49d37dcdb1e08f9ec08ff52a31e26ff1c12c44
parent 722188 32d44a70fa67baf098784fce7033fc00f9613410
child 722190 02ed4fbb2629b31cd0b571e4a8b75c21fa2ae647
push id96080
push userbmo:nox@mozilla.com
push dateThu, 18 Jan 2018 16:12:25 +0000
reviewersbz
bugs1431449
milestone59.0a1
Bug 1431449 - Make URLParams::DecodeString static; r?bz MozReview-Commit-ID: KKoaxHSnmSz
dom/url/URLSearchParams.cpp
dom/url/URLSearchParams.h
--- a/dom/url/URLSearchParams.cpp
+++ b/dom/url/URLSearchParams.cpp
@@ -93,25 +93,25 @@ URLParams::Delete(const nsAString& aName
     if (mParams[i].mKey.Equals(aName)) {
       mParams.RemoveElementAt(i);
     } else {
       ++i;
     }
   }
 }
 
-void
+/* static */ void
 URLParams::ConvertString(const nsACString& aInput, nsAString& aOutput)
 {
   if (NS_FAILED(UTF_8_ENCODING->DecodeWithoutBOMHandling(aInput, aOutput))) {
     MOZ_CRASH("Out of memory when converting URL params.");
   }
 }
 
-void
+/* static */ void
 URLParams::DecodeString(const nsACString& aInput, nsAString& aOutput)
 {
   nsACString::const_iterator start, end;
   aInput.BeginReading(start);
   aInput.EndReading(end);
 
   nsCString unescaped;
 
--- a/dom/url/URLSearchParams.h
+++ b/dom/url/URLSearchParams.h
@@ -108,18 +108,18 @@ public:
 
   bool
   ReadStructuredClone(JSStructuredCloneReader* aReader);
 
   bool
   WriteStructuredClone(JSStructuredCloneWriter* aWriter) const;
 
 private:
-  void DecodeString(const nsACString& aInput, nsAString& aOutput);
-  void ConvertString(const nsACString& aInput, nsAString& aOutput);
+  static void DecodeString(const nsACString& aInput, nsAString& aOutput);
+  static void ConvertString(const nsACString& aInput, nsAString& aOutput);
 
   struct Param
   {
     nsString mKey;
     nsString mValue;
   };
 
   nsTArray<Param> mParams;