Bug 1431449 - Kill URLSearchParams::ForEach; r?bz draft
authorAnthony Ramine <n.oxyde@gmail.com>
Thu, 18 Jan 2018 12:20:26 +0100
changeset 722187 eee02425c05a05e768a7dd6ff3bfc0b848a0b99c
parent 721726 fb618bea01d793a7cc1d3283aa6e3f6a32807df8
child 722188 32d44a70fa67baf098784fce7033fc00f9613410
push id96080
push userbmo:nox@mozilla.com
push dateThu, 18 Jan 2018 16:12:25 +0000
reviewersbz
bugs1431449
milestone59.0a1
Bug 1431449 - Kill URLSearchParams::ForEach; r?bz MozReview-Commit-ID: 9woZBRwpb4T
dom/base/BodyUtil.cpp
dom/url/URLSearchParams.h
--- a/dom/base/BodyUtil.cpp
+++ b/dom/base/BodyUtil.cpp
@@ -41,17 +41,17 @@ PushOverLine(nsACString::const_iterator&
     ++aStart; // advance to after CRLF
     return true;
   }
 
   return false;
 }
 
 class MOZ_STACK_CLASS FillFormIterator final
-  : public URLSearchParams::ForEachIterator
+  : public URLParams::ForEachIterator
 {
 public:
   explicit FillFormIterator(FormData* aFormData)
     : mFormData(aFormData)
   {
     MOZ_ASSERT(aFormData);
   }
 
--- a/dom/url/URLSearchParams.h
+++ b/dom/url/URLSearchParams.h
@@ -172,26 +172,16 @@ public:
 
   void Sort(ErrorResult& aRv);
 
   void Stringify(nsString& aRetval) const
   {
     Serialize(aRetval);
   }
 
-  typedef URLParams::ForEachIterator ForEachIterator;
-
-  bool
-  ForEach(ForEachIterator& aIterator) const
-  {
-    return mParams->ForEach(aIterator);
-
-    return true;
-  }
-
   bool
   ReadStructuredClone(JSStructuredCloneReader* aReader);
 
   bool
   WriteStructuredClone(JSStructuredCloneWriter* aWriter) const;
 
 private:
   void AppendInternal(const nsAString& aName, const nsAString& aValue);