Bug 1430799 - Add a createObjectClient method to the DebuggerClient;r=jlast. draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Tue, 16 Jan 2018 17:25:58 +0100
changeset 720960 a279790045eb91d96d20fca522e1b38c01d72a49
parent 720848 e4107773cffb1baefd5446666fce22c4d6eb0517
child 746210 5603b5d3c385bd94f2187fd6675982e7cc531e26
push id95706
push userbmo:nchevobbe@mozilla.com
push dateTue, 16 Jan 2018 16:26:50 +0000
reviewersjlast
bugs1430799
milestone59.0a1
Bug 1430799 - Add a createObjectClient method to the DebuggerClient;r=jlast. This is needed by the debugger in order to use the latest devtools-reps package (0.19.0). This function was already added in the devtools-connection package. MozReview-Commit-ID: 3SVxq4Jbs16
devtools/shared/client/debugger-client.js
--- a/devtools/shared/client/debugger-client.js
+++ b/devtools/shared/client/debugger-client.js
@@ -24,16 +24,17 @@ loader.lazyRequireGetter(this, "getDevic
 
 loader.lazyRequireGetter(this, "WebConsoleClient", "devtools/shared/webconsole/client", true);
 loader.lazyRequireGetter(this, "AddonClient", "devtools/shared/client/addon-client");
 loader.lazyRequireGetter(this, "RootClient", "devtools/shared/client/root-client");
 loader.lazyRequireGetter(this, "TabClient", "devtools/shared/client/tab-client");
 loader.lazyRequireGetter(this, "ThreadClient", "devtools/shared/client/thread-client");
 loader.lazyRequireGetter(this, "TraceClient", "devtools/shared/client/trace-client");
 loader.lazyRequireGetter(this, "WorkerClient", "devtools/shared/client/worker-client");
+loader.lazyRequireGetter(this, "ObjectClient", "devtools/shared/client/object-client");
 
 const noop = () => {};
 
 // Define the minimum officially supported version of Firefox when connecting to a remote
 // runtime. (Use ".0a1" to support the very first nightly version)
 // This is usually the current ESR version.
 const MIN_SUPPORTED_PLATFORM_VERSION = "52.0a1";
 const MS_PER_DAY = 86400000;
@@ -1189,17 +1190,26 @@ DebuggerClient.prototype = {
       }
     }
     return null;
   },
 
   /**
    * Currently attached addon.
    */
-  activeAddon: null
+  activeAddon: null,
+
+  /**
+   * Creates an object client for this DebuggerClient and the grip in parameter,
+   * @param {Object} grip: The grip to create the ObjectClient for.
+   * @returns {ObjectClient}
+   */
+  createObjectClient: function (grip) {
+    return new ObjectClient(this, grip);
+  }
 };
 
 eventSource(DebuggerClient.prototype);
 
 class Request extends EventEmitter {
   constructor(request) {
     super();
     this.request = request;