Bug 1430425 - VideoStreamFactory constructor should pass codec name by reference r?dminor draft
authorJean-Luc Bonnafoux <jeanluc.bonnafoux@wanadoo.fr>
Sun, 14 Jan 2018 17:26:26 +0100
changeset 720168 ba2281a150fcdafebe616f3ead2d5c5d3183f35d
parent 720019 fa2726ccee21599eccafe42eb394dd7e5ea43d6b
child 720169 d51a95a246666dfbbac37c296f61e3cd913056dd
push id95463
push userbmo:jeanluc.bonnafoux@wanadoo.fr
push dateSun, 14 Jan 2018 16:31:50 +0000
reviewersdminor
bugs1430425
milestone59.0a1
Bug 1430425 - VideoStreamFactory constructor should pass codec name by reference r?dminor MozReview-Commit-ID: 8rUH1DfEUts
media/webrtc/signaling/src/media-conduit/VideoConduit.h
--- a/media/webrtc/signaling/src/media-conduit/VideoConduit.h
+++ b/media/webrtc/signaling/src/media-conduit/VideoConduit.h
@@ -442,17 +442,17 @@ private:
   bool CodecsDifferent(const nsTArray<UniquePtr<VideoCodecConfig>>& a,
                        const nsTArray<UniquePtr<VideoCodecConfig>>& b);
 
   // Factory class for VideoStreams... vie_encoder.cc will call this to reconfigure.
   // We need to give it access to the conduit to make it's decisions
   class VideoStreamFactory : public webrtc::VideoEncoderConfig::VideoStreamFactoryInterface
   {
   public:
-    VideoStreamFactory(std::string aCodecName,
+    VideoStreamFactory(const std::string& aCodecName,
                        WebrtcVideoConduit *aConduit)
       : mCodecName(aCodecName),
         mConduit(aConduit) {}
 
   private:
     std::vector<webrtc::VideoStream>
       CreateEncoderStreams(int width, int height,
                            const webrtc::VideoEncoderConfig& config) override;