bug 1430115 - Add back historical record_in_processes value 'all_childs' r?Dexter draft
authorChris H-C <chutten@mozilla.com>
Fri, 12 Jan 2018 09:36:09 -0500
changeset 719651 a591f23ebba3442d290fa1f6db3b9d32a5298c67
parent 719593 d2edd256c3aadb1cea48da0c8f62f725bd53cb76
child 745854 900ad9087c2983fa181df73af9937c549081cae8
push id95317
push userbmo:chutten@mozilla.com
push dateFri, 12 Jan 2018 14:44:09 +0000
reviewersDexter
bugs1430115
milestone59.0a1
bug 1430115 - Add back historical record_in_processes value 'all_childs' r?Dexter Once again I forgot that shared_telemetry_utils is used to help parse historical Histograms.json/Scalars.yaml/Events.yaml files in addition to modern ones. We need to maintain backwards-compatibility. MozReview-Commit-ID: FMbfYfRycQ7
toolkit/components/telemetry/shared_telemetry_utils.py
--- a/toolkit/components/telemetry/shared_telemetry_utils.py
+++ b/toolkit/components/telemetry/shared_telemetry_utils.py
@@ -8,22 +8,26 @@
 from __future__ import print_function
 
 import re
 import yaml
 import sys
 
 # This is a list of flags that determine which process a measurement is allowed
 # to record from.
+# This map has to contain all historical values as well, since it is used for
+# validating historical files as well as current ones.
 KNOWN_PROCESS_FLAGS = {
     'all': 'All',
     'all_children': 'AllChildren',
     'main': 'Main',
     'content': 'Content',
     'gpu': 'Gpu',
+    # Historical Values
+    'all_childs': 'AllChildren', # Supporting files from before bug 1363725
 }
 
 PROCESS_ENUM_PREFIX = "mozilla::Telemetry::Common::RecordedProcessType::"
 
 
 class ParserError(Exception):
     """Thrown by different probe parsers. Errors are partitioned into
     'immediately fatal' and 'eventually fatal' so that the parser can print