Bug 888784 - Make FormHistory update transaction immediate. r?mak draft
authorMike Conley <mconley@mozilla.com>
Tue, 09 Jan 2018 14:16:35 -0500
changeset 719310 3abb239af8b727943a3cf1235c6f60cbf3311756
parent 717770 81aaeafb34533b3bddaa30e7d6ed942b3e59bc21
child 719311 2dc75a9c99cc6b3895c38faa101a132db126b612
push id95218
push usermconley@mozilla.com
push dateThu, 11 Jan 2018 22:21:55 +0000
reviewersmak
bugs888784
milestone59.0a1
Bug 888784 - Make FormHistory update transaction immediate. r?mak The transaction was immediate before when using mozIStorageService, but accidentally used the deferred default when transitioned to Sqlite.jsm. This puts us back into the immediate mode for update transactions. MozReview-Commit-ID: 9apF4o6GFI7
toolkit/components/satchel/FormHistory.jsm
--- a/toolkit/components/satchel/FormHistory.jsm
+++ b/toolkit/components/satchel/FormHistory.jsm
@@ -486,17 +486,17 @@ async function updateFormHistoryWrite(aC
  * @param {Object} queries query string and param pairs generated
  *                 by updateFormHistoryWrite
  */
 async function runUpdateQueries(conn, queries) {
   await conn.executeTransaction(async () => {
     for (let { query, params } of queries) {
       await conn.executeCached(query, params);
     }
-  });
+  }, conn.TRANSACTION_IMMEDIATE);
 }
 
 /**
  * Functions that expire entries in form history and shrinks database
  * afterwards as necessary initiated by expireOldEntries.
  */
 
 /**