Bug 1420934 - Ensure `npm install` on netmonitor before installing in webconsole;r=Honza draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Thu, 11 Jan 2018 09:28:52 -0800
changeset 719222 9a8487fccd7c8641f47dcc405be3c8324bf8474c
parent 719102 c4e4613dbe32bb218957a140e5d0bd4fe7d1e98c
child 745731 cd1232a9ee40bd6b97f323d981bad52f5f746359
push id95185
push userbgrinstead@mozilla.com
push dateThu, 11 Jan 2018 17:29:16 +0000
reviewersHonza
bugs1420934
milestone59.0a1
Bug 1420934 - Ensure `npm install` on netmonitor before installing in webconsole;r=Honza If the netmonitor hasn't had `npm install` ran, then running the webconsole tests fail, because the webconsole depends on netmonitor, and the babel plugin "transform-object-rest-spread" defined in netmonitor/.babelrc cannot be resolved unless if it's been installed. MozReview-Commit-ID: KyQgja5rRpg
devtools/client/webconsole/package.json
--- a/devtools/client/webconsole/package.json
+++ b/devtools/client/webconsole/package.json
@@ -1,15 +1,16 @@
 {
   "name": "webconsole",
   "version": "0.0.1",
   "engines": {
     "node": ">=6.9.0"
   },
   "scripts": {
+    "preinstall": "cd ../netmonitor && npm install && cd ../webconsole",
     "start": "cross-env NODE_ENV=production node bin/dev-server",
     "dev": "node bin/dev-server",
     "test": "cross-env NODE_ENV=test NODE_PATH=../../../ mocha new-console-output/test/**/*.test.js --compilers js:babel-register -r jsdom-global/register -r ./new-console-output/test/require-helper.js"
   },
   "dependencies": {
     "amd-loader": "0.0.5",
     "babel-preset-es2015": "^6.6.0",
     "babel-preset-es2017": "^6.24.1",