Bug 1429249 - Don't prevent link navigation when clicking on tiles. r=Mardak draft
authorAndrei Oprea <andrei.br92@gmail.com>
Wed, 10 Jan 2018 12:26:51 +0100
changeset 718586 34c8e2f9206314a2e4121eb084a42e3fc4e916d4
parent 718505 d5f42a23909eb181274731b07e4984bfbd18557d
child 745542 52cfc775c30e41a5edd97ace44679138dbdaf8f2
push id94988
push userbmo:andrei.br92@gmail.com
push dateWed, 10 Jan 2018 16:28:58 +0000
reviewersMardak
bugs1429249
milestone59.0a1
Bug 1429249 - Don't prevent link navigation when clicking on tiles. r=Mardak MozReview-Commit-ID: 6QTFe93QP97
browser/base/content/newtab/sites.js
--- a/browser/base/content/newtab/sites.js
+++ b/browser/base/content/newtab/sites.js
@@ -242,21 +242,22 @@ Site.prototype = {
     } catch (e) {}
   },
 
   /**
    * Handles site click events.
    */
   onClick: function Site_onClick(aEvent) {
     let pinned = this.isPinned();
-    let tileIndex = this.cell.index;
     let {button, target} = aEvent;
+    const isLinkClick = target.classList.contains("newtab-link") ||
+      target.parentElement.classList.contains("newtab-link");
 
-    // Only handle primary clicks for the remaining targets
-    if (button == 0) {
+    // Handle primary click for pin and block
+    if (button == 0 && !isLinkClick) {
       aEvent.preventDefault();
       if (target.classList.contains("newtab-control-block")) {
         this.block();
       }
       else if (pinned && target.classList.contains("newtab-control-pin")) {
         this.unpin();
       }
       else if (!pinned && target.classList.contains("newtab-control-pin")) {