Bug 1429082 - Drop SyncChromeSender from proxy module. r?whimboo draft
authorAndreas Tolfsen <ato@sny.no>
Tue, 09 Jan 2018 15:42:55 +0000
changeset 717791 5ef7053d0e946b073e99e11a7931011ab858ccc1
parent 717790 943f5ef6be567d57d7c03c49513f6afecb07731b
child 745340 19cef18663dc2f0bb5cbaacc5f94a706b1d647df
push id94773
push userbmo:ato@sny.no
push dateTue, 09 Jan 2018 15:45:17 +0000
reviewerswhimboo
bugs1429082
milestone59.0a1
Bug 1429082 - Drop SyncChromeSender from proxy module. r?whimboo The SyncChromeSender class and its factory construction function proxy.toChrome is not used in Marionette and can be safely removed. MozReview-Commit-ID: jBJ0nIkn3i
testing/marionette/proxy.js
--- a/testing/marionette/proxy.js
+++ b/testing/marionette/proxy.js
@@ -316,59 +316,14 @@ proxy.AsyncMessageChannel = class {
   }
 };
 proxy.AsyncMessageChannel.ReplyType = {
   Ok: 0,
   Value: 1,
   Error: 2,
 };
 
-/**
- * Creates a transparent interface from the content- to the chrome context.
- *
- * Calls to this object will be proxied via the frame's sendSyncMessage
- * ({@link nsISyncMessageSender}) function.  Since the message is
- * synchronous, the return value is presented as a return value.
- *
- * Example on how to use from a frame content script:
- *
- * <pre><code>
- *     let chrome = proxy.toChrome(sendSyncMessage.bind(this));
- *     let cookie = chrome.getCookie("foo");
- * </code></pre>
- *
- * @param {nsISyncMessageSender} sendSyncMessageFn
- *     The frame message manager's sendSyncMessage function.
- */
-proxy.toChrome = function(sendSyncMessageFn) {
-  let sender = new proxy.SyncChromeSender(sendSyncMessageFn);
-  return new Proxy(sender, ownPriorityGetterTrap);
-};
-
-/**
- * The SyncChromeSender sends synchronous RPC messages to the chrome
- * context, using a frame's sendSyncMessage ({@link nsISyncMessageSender})
- * function.
- *
- * Example on how to use from a frame content script:
- *
- * <pre><code>
- *     let sender = new SyncChromeSender(sendSyncMessage.bind(this));
- *     let res = sender.send("addCookie", cookie);
- * </code></pre>
- */
-proxy.SyncChromeSender = class {
-  constructor(sendSyncMessage) {
-    this.sendSyncMessage_ = sendSyncMessage;
-  }
-
-  send(func, args) {
-    let name = "Marionette:" + func.toString();
-    return this.sendSyncMessage_(name, marshal(args));
-  }
-};
-
 function marshal(args) {
   if (args.length == 1 && typeof args[0] == "object") {
     return args[0];
   }
   return args;
 }