Bug 1426250 - allow changing log preference at runtime for CUI.jsm, r?jaws draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Fri, 05 Jan 2018 21:31:53 +0000
changeset 717670 da16c6bfb67b06d03ded21f5a5eaa7d37a610d04
parent 717669 4a29dfc44a10a66f5ecd242740d976653d4448af
child 717671 fa5d9d9664c4608d57f1fee357b53610ad2e2926
push id94744
push userbmo:gijskruitbosch+bugs@gmail.com
push dateTue, 09 Jan 2018 10:07:53 +0000
reviewersjaws
bugs1426250
milestone59.0a1
Bug 1426250 - allow changing log preference at runtime for CUI.jsm, r?jaws MozReview-Commit-ID: 9kYBC27wowg
browser/components/customizableui/CustomizableUI.jsm
--- a/browser/components/customizableui/CustomizableUI.jsm
+++ b/browser/components/customizableui/CustomizableUI.jsm
@@ -157,22 +157,24 @@ var gUIStateBeforeReset = {
   currentTheme: null,
   uiDensity: null,
   autoTouchMode: null,
 };
 
 XPCOMUtils.defineLazyGetter(this, "log", () => {
   let scope = {};
   Cu.import("resource://gre/modules/Console.jsm", scope);
-  let debug = Services.prefs.getBoolPref(kPrefCustomizationDebug, false);
+  XPCOMUtils.defineLazyPreferenceGetter(this, "gDebuggingEnabled", kPrefCustomizationDebug, false,
+    (pref, oldVal, newVal) => log.maxLogLevel = newVal ? "all" : "log");
   let consoleOptions = {
-    maxLogLevel: debug ? "all" : "log",
+    maxLogLevel: gDebuggingEnabled ? "all" : "log", // eslint-disable-line no-undef
     prefix: "CustomizableUI",
   };
-  return new scope.ConsoleAPI(consoleOptions);
+  let log = new scope.ConsoleAPI(consoleOptions);
+  return log;
 });
 
 var CustomizableUIInternal = {
   initialize() {
     log.debug("Initializing");
 
     this.addListener(this);
     this._defineBuiltInWidgets();