Bug 685236 - Stop using GetNativePath in rdf/. r?Pike draft
authorMasatoshi Kimura <VYV03354@nifty.ne.jp>
Fri, 15 Dec 2017 21:15:09 +0900
changeset 715689 ccbd334d7994b68a71a4dd34573a6245c17bde54
parent 715688 87146c34c0dec7e7a60ef7f668390a521f63db92
child 715690 b957358ab015866ee4a5449521c6f5006d86c4b7
push id94228
push userVYV03354@nifty.ne.jp
push dateThu, 04 Jan 2018 11:56:10 +0000
reviewersPike
bugs685236
milestone59.0a1
Bug 685236 - Stop using GetNativePath in rdf/. r?Pike MozReview-Commit-ID: GeGzQUjqQid
rdf/datasource/nsFileSystemDataSource.cpp
rdf/datasource/nsFileSystemDataSource.h
--- a/rdf/datasource/nsFileSystemDataSource.cpp
+++ b/rdf/datasource/nsFileSystemDataSource.cpp
@@ -181,17 +181,17 @@ FileSystemDataSource::Init()
     nsCOMPtr<nsIFile> file;
     NS_GetSpecialDirectory(NS_WIN_FAVORITES_DIR, getter_AddRefs(file));
     if (file)
     {
         nsCOMPtr<nsIURI> furi;
         NS_NewFileURI(getter_AddRefs(furi), file);
         NS_ENSURE_TRUE(furi, NS_ERROR_FAILURE);
 
-        file->GetNativePath(ieFavoritesDir);
+        file->GetPath(ieFavoritesDir);
     }
 #endif
 
     return NS_OK;
 }
 
 //static
 nsresult
@@ -1165,17 +1165,18 @@ FileSystemDataSource::GetName(nsIRDFReso
         return(rv);
     if (name.IsEmpty())
         return(NS_ERROR_UNEXPECTED);
 
 #ifdef  XP_WIN
     // special hack for IE favorites under Windows; strip off the
     // trailing ".url" or ".lnk" at the end of IE favorites names
     int32_t nameLen = name.Length();
-    if ((strncmp(uri, ieFavoritesDir.get(), ieFavoritesDir.Length()) == 0) && (nameLen > 4))
+    if ((NS_strncmp(NS_ConvertUTF8toUTF16(uri).get(),
+                    ieFavoritesDir.get(), ieFavoritesDir.Length()) == 0) && (nameLen > 4))
     {
         nsAutoString extension;
         name.Right(extension, 4);
         if (extension.LowerCaseEqualsLiteral(".url") ||
             extension.LowerCaseEqualsLiteral(".lnk"))
         {
             name.Truncate(nameLen - 4);
         }
--- a/rdf/datasource/nsFileSystemDataSource.h
+++ b/rdf/datasource/nsFileSystemDataSource.h
@@ -67,13 +67,13 @@ private:
     nsCOMPtr<nsIRDFResource>       mNC_extension;
 #endif
 
 #ifdef  XP_WIN
     bool     isValidFolder(nsIRDFResource *source);
     nsresult getIEFavoriteURL(nsIRDFResource *source, nsString aFileURL, nsIRDFLiteral **urlLiteral);
     nsCOMPtr<nsIRDFResource>       mNC_IEFavoriteObject;
     nsCOMPtr<nsIRDFResource>       mNC_IEFavoriteFolder;
-    nsCString                      ieFavoritesDir;
+    nsString                       ieFavoritesDir;
 #endif
 };
 
 #endif // nsFileSystemDataSource_h__