Bug 1427484 - Fix about:telemetry "Show raw stack data" button in Browser Hangs section. r=chutten
The "Show raw stack data" button in the Browser Hangs section produced nothing but removing the "Browser Hangs" section from the about:telemetry navigation menu. I looked at the way the Late Writes section works and patched the Chrome Hangs render calls accordingly.
MozReview-Commit-ID: Gq681oVrg90
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -1055,26 +1055,25 @@ function SymbolicationRequest_fetchSymbo
var ChromeHangs = {
symbolRequest: null,
/**
* Renders raw chrome hang data
*/
- render: function ChromeHangs_render(payload) {
- let hangs = payload.chromeHangs;
- setHasData("chrome-hangs-section", !!hangs);
- if (!hangs) {
+ render: function ChromeHangs_render(chromeHangs) {
+ setHasData("chrome-hangs-section", !!chromeHangs);
+ if (!chromeHangs) {
return;
}
- let stacks = hangs.stacks;
- let memoryMap = hangs.memoryMap;
- let durations = hangs.durations;
+ let stacks = chromeHangs.stacks;
+ let memoryMap = chromeHangs.memoryMap;
+ let durations = chromeHangs.durations;
StackRenderer.renderStacks("chrome-hangs", stacks, memoryMap,
(index) => this.renderHangHeader(index, durations));
},
renderHangHeader: function ChromeHangs_renderHangHeader(aIndex, aDurations) {
StackRenderer.renderHeader("chrome-hangs", [aIndex + 1, aDurations[aIndex]]);
}
@@ -2048,17 +2047,17 @@ function setupListeners() {
});
document.getElementById("chrome-hangs-hide-symbols").addEventListener("click",
function() {
if (!gPingData) {
return;
}
- ChromeHangs.render(gPingData);
+ ChromeHangs.render(gPingData.payload.chromeHangs);
});
document.getElementById("captured-stacks-fetch-symbols").addEventListener("click",
function() {
if (!gPingData) {
return;
}
let capturedStacks = gPingData.payload.processes.parent.capturedStacks;