Bug 1426634 - Rename devtools/client/shared/components/Tree.js to VirtualizedTree.js; r=nchevobbe
MozReview-Commit-ID: 80ebj9CJODR
--- a/devtools/client/memory/components/Census.js
+++ b/devtools/client/memory/components/Census.js
@@ -1,17 +1,17 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
const { Component, createFactory } = require("devtools/client/shared/vendor/react");
const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
-const Tree = createFactory(require("devtools/client/shared/components/Tree"));
+const Tree = createFactory(require("devtools/client/shared/components/VirtualizedTree"));
const CensusTreeItem = createFactory(require("./CensusTreeItem"));
const { TREE_ROW_HEIGHT } = require("../constants");
const { censusModel, diffingModel } = require("../models");
class Census extends Component {
static get propTypes() {
return {
census: censusModel,
--- a/devtools/client/memory/components/DominatorTree.js
+++ b/devtools/client/memory/components/DominatorTree.js
@@ -4,17 +4,17 @@
"use strict";
const { Component, createFactory } = require("devtools/client/shared/vendor/react");
const dom = require("devtools/client/shared/vendor/react-dom-factories");
const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
const { assert } = require("devtools/shared/DevToolsUtils");
const { createParentMap } = require("devtools/shared/heapsnapshot/CensusUtils");
-const Tree = createFactory(require("devtools/client/shared/components/Tree"));
+const Tree = createFactory(require("devtools/client/shared/components/VirtualizedTree"));
const DominatorTreeItem = createFactory(require("./DominatorTreeItem"));
const { L10N } = require("../utils");
const { TREE_ROW_HEIGHT, dominatorTreeState } = require("../constants");
const { dominatorTreeModel } = require("../models");
const DominatorTreeLazyChildren = require("../dominator-tree-lazy-children");
const DOMINATOR_TREE_AUTO_EXPAND_DEPTH = 3;
--- a/devtools/client/memory/components/Individuals.js
+++ b/devtools/client/memory/components/Individuals.js
@@ -1,17 +1,17 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
const { Component, createFactory } = require("devtools/client/shared/vendor/react");
const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
-const Tree = createFactory(require("devtools/client/shared/components/Tree"));
+const Tree = createFactory(require("devtools/client/shared/components/VirtualizedTree"));
const DominatorTreeItem = createFactory(require("./DominatorTreeItem"));
const { TREE_ROW_HEIGHT } = require("../constants");
const models = require("../models");
/**
* The list of individuals in a census group.
*/
class Individuals extends Component {
--- a/devtools/client/performance/components/jit-optimizations.js
+++ b/devtools/client/performance/components/jit-optimizations.js
@@ -6,17 +6,17 @@
const { LocalizationHelper } = require("devtools/shared/l10n");
const STRINGS_URI = "devtools/client/locales/jit-optimizations.properties";
const L10N = new LocalizationHelper(STRINGS_URI);
const { assert } = require("devtools/shared/DevToolsUtils");
const { Component, createFactory } = require("devtools/client/shared/vendor/react");
const dom = require("devtools/client/shared/vendor/react-dom-factories");
const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
-const Tree = createFactory(require("../../shared/components/Tree"));
+const Tree = createFactory(require("devtools/client/shared/components/VirtualizedTree"));
const OptimizationsItem = createFactory(require("./jit-optimizations-item"));
const FrameView = createFactory(require("../../shared/components/Frame"));
const JIT_TITLE = L10N.getStr("jit.title");
// If TREE_ROW_HEIGHT changes, be sure to change `var(--jit-tree-row-height)`
// in `devtools/client/themes/jit-optimizations.css`
const TREE_ROW_HEIGHT = 14;
/* eslint-disable no-unused-vars */
--- a/devtools/client/performance/components/waterfall-tree.js
+++ b/devtools/client/performance/components/waterfall-tree.js
@@ -1,16 +1,16 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
const { Component, createFactory } = require("devtools/client/shared/vendor/react");
const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
-const Tree = createFactory(require("devtools/client/shared/components/Tree"));
+const Tree = createFactory(require("devtools/client/shared/components/VirtualizedTree"));
const WaterfallTreeRow = createFactory(require("./waterfall-tree-row"));
// Keep in sync with var(--waterfall-tree-row-height) in performance.css
const WATERFALL_TREE_ROW_HEIGHT = 15; // px
/**
* Checks if a given marker is in the specified time range.
*
rename from devtools/client/shared/components/Tree.js
rename to devtools/client/shared/components/VirtualizedTree.js
--- a/devtools/client/shared/components/moz.build
+++ b/devtools/client/shared/components/moz.build
@@ -16,14 +16,14 @@ DevToolsModules(
'Frame.js',
'HSplitBox.js',
'NotificationBox.css',
'NotificationBox.js',
'SearchBox.js',
'SidebarToggle.css',
'SidebarToggle.js',
'StackTrace.js',
- 'Tree.js',
+ 'VirtualizedTree.js',
'VisibilityHandler.js',
)
MOCHITEST_CHROME_MANIFESTS += ['test/mochitest/chrome.ini']
BROWSER_CHROME_MANIFESTS += ['test/browser/browser.ini']
--- a/devtools/client/shared/components/test/mochitest/test_tree_01.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_01.html
@@ -16,17 +16,17 @@ depth.
<body>
<pre id="test">
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
let ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
let React = browserRequire("devtools/client/shared/vendor/react");
- let Tree = React.createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ let Tree = React.createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
ok(React, "Should get React");
ok(Tree, "Should get Tree");
const t = Tree(TEST_TREE_INTERFACE);
ok(t, "Should be able to create Tree instances");
const tree = ReactDOM.render(t, window.document.body);
--- a/devtools/client/shared/components/test/mochitest/test_tree_02.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_02.html
@@ -15,17 +15,17 @@ Test that collapsed subtrees aren't rend
<body>
<pre id="test">
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
let ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
let React = browserRequire("devtools/client/shared/vendor/react");
- let Tree = React.createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ let Tree = React.createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
const tree = ReactDOM.render(Tree(TEST_TREE_INTERFACE), window.document.body);
isAccessibleTree(tree);
TEST_TREE.expanded = new Set("MNO".split(""));
yield forceRender(tree);
isRenderedTree(document.body.textContent, [
--- a/devtools/client/shared/components/test/mochitest/test_tree_03.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_03.html
@@ -15,17 +15,17 @@ Test Tree's autoExpandDepth.
<body>
<pre id="test">
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
let ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
let React = browserRequire("devtools/client/shared/vendor/react");
- let Tree = React.createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ let Tree = React.createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
const tree = ReactDOM.render(Tree(Object.assign({}, TEST_TREE_INTERFACE, {
autoExpandDepth: 1
})), window.document.body);
isAccessibleTree(tree);
isRenderedTree(document.body.textContent, [
"A:false",
--- a/devtools/client/shared/components/test/mochitest/test_tree_04.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_04.html
@@ -24,17 +24,17 @@ window.onload = Task.async(function* ()
bottom: document.querySelector(".tree > div:last-of-type").clientHeight,
};
}
const ITEM_HEIGHT = 3;
const ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
const React = browserRequire("devtools/client/shared/vendor/react");
- const Tree = React.createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ const Tree = React.createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
const tree = ReactDOM.render(
Tree(Object.assign({}, TEST_TREE_INTERFACE, { itemHeight: ITEM_HEIGHT })),
window.document.body);
TEST_TREE.expanded = new Set("ABCDEFGHIJKLMNO".split(""));
yield setState(tree, {
--- a/devtools/client/shared/components/test/mochitest/test_tree_05.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_05.html
@@ -16,17 +16,17 @@ Test focusing with the Tree component.
<pre id="test">
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
const ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
const { createFactory } = browserRequire("devtools/client/shared/vendor/react");
- const Tree = createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ const Tree = createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
function renderTree(props) {
const treeProps = Object.assign({},
TEST_TREE_INTERFACE,
{ onFocus: x => renderTree({ focused: x }) },
props
);
return ReactDOM.render(Tree(treeProps), window.document.body);
--- a/devtools/client/shared/components/test/mochitest/test_tree_06.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_06.html
@@ -16,17 +16,17 @@ Test keyboard navigation with the Tree c
<pre id="test">
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
const ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
const { createFactory } = browserRequire("devtools/client/shared/vendor/react");
const { Simulate } = ReactDOM.TestUtils;
- const Tree = createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ const Tree = createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
function renderTree(props) {
const treeProps = Object.assign({},
TEST_TREE_INTERFACE,
{ onFocus: x => renderTree({ focused: x }) },
props
);
return ReactDOM.render(Tree(treeProps), window.document.body);
--- a/devtools/client/shared/components/test/mochitest/test_tree_07.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_07.html
@@ -18,17 +18,17 @@ Test that arrows get the open attribute
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
const ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
const React = browserRequire("devtools/client/shared/vendor/react");
const dom = require("devtools/client/shared/vendor/react-dom-factories");
const Tree =
- React.createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ React.createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
const treeProps = Object.assign({}, TEST_TREE_INTERFACE, {
renderItem: (item, depth, focused, arrow) => {
return dom.div(
{
id: item,
style: { marginLeft: depth * 16 + "px" }
},
--- a/devtools/client/shared/components/test/mochitest/test_tree_08.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_08.html
@@ -17,17 +17,17 @@ other inputs.
<body>
<pre id="test">
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
const ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
const { createFactory } = browserRequire("devtools/client/shared/vendor/react");
- const Tree = createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ const Tree = createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
function renderTree(props) {
const treeProps = Object.assign({},
TEST_TREE_INTERFACE,
{ onFocus: x => renderTree({ focused: x }) },
props
);
return ReactDOM.render(Tree(treeProps), window.document.body);
--- a/devtools/client/shared/components/test/mochitest/test_tree_09.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_09.html
@@ -17,17 +17,17 @@ Test that when an item in the Tree compo
<pre id="test">
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
const ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
const { createFactory } = browserRequire("devtools/client/shared/vendor/react");
const { Simulate } = ReactDOM.TestUtils;
- const Tree = createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ const Tree = createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
let numberOfExpands = 0;
let lastExpandedItem = null;
let numberOfCollapses = 0;
let lastCollapsedItem = null;
function renderTree(props) {
--- a/devtools/client/shared/components/test/mochitest/test_tree_10.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_10.html
@@ -16,17 +16,17 @@ Test that when an item in the Tree compo
<body>
<pre id="test">
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
const ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
const { createFactory } = browserRequire("devtools/client/shared/vendor/react");
- const Tree = createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ const Tree = createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
function renderTree(props) {
const treeProps = Object.assign({},
TEST_TREE_INTERFACE,
{ autoExpandDepth: 1 },
props
);
return ReactDOM.render(Tree(treeProps), window.document.body);
--- a/devtools/client/shared/components/test/mochitest/test_tree_11.html
+++ b/devtools/client/shared/components/test/mochitest/test_tree_11.html
@@ -28,17 +28,17 @@ Test that when an item in the Tree compo
<pre id="test">
<script src="head.js" type="application/javascript"></script>
<script type="application/javascript">
window.onload = Task.async(function* () {
try {
const ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
const { createFactory } = browserRequire("devtools/client/shared/vendor/react");
const { Simulate } = ReactDOM.TestUtils;
- const Tree = createFactory(browserRequire("devtools/client/shared/components/Tree"));
+ const Tree = createFactory(browserRequire("devtools/client/shared/components/VirtualizedTree"));
TEST_TREE.expanded = new Set("ABCDEFGHIJKLMNO".split(""));
function renderTree(props) {
const treeProps = Object.assign({},
TEST_TREE_INTERFACE,
{
itemHeight: 10,