Bug 1426864 - Determine private mode via browser toolbar, 2nd edition. r?
Similar to maybeSwitchToTab in
bug 1426613, a search might be launched while we
don't have a selected tab yet. Therefore we determine private mode state via the
browser toolbar instead.
MozReview-Commit-ID: 4idUR8v7MCx
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -4305,17 +4305,17 @@ public class BrowserApp extends GeckoApp
}
// BrowserSearch.OnSearchListener
@Override
public void onSearch(SearchEngine engine, final String text, final TelemetryContract.Method method) {
// Don't store searches that happen in private tabs. This assumes the user can only
// perform a search inside the currently selected tab, which is true for searches
// that come from SearchEngineRow.
- if (!Tabs.getInstance().getSelectedTab().isPrivate()) {
+ if (!mBrowserToolbar.isPrivateMode()) {
storeSearchQuery(text);
}
// We don't use SearchEngine.getEngineIdentifier because it can
// return a custom search engine name, which is a privacy concern.
final String identifierToRecord = (engine.identifier != null) ? engine.identifier : "other";
recordSearch(GeckoSharedPrefs.forProfile(this), identifierToRecord, method);
openUrlAndStopEditing(text, engine.name);