Bug 1426719 - Workaround a bug in Windows Insider build 17063 which breaks sound in Firefox. draft
authorZibi Braniecki <zbraniecki@mozilla.com>
Thu, 21 Dec 2017 19:29:44 +0100
changeset 714095 56d8588730a63bb850cb78a461d239c7f40501ef
parent 713235 1624b88874765bf57e9feba176d30149c748d9d2
child 744524 75387319f61c44e9e2fa0434c2e29e7362f5d6d1
push id93851
push userbmo:gandalf@aviary.pl
push dateThu, 21 Dec 2017 18:30:10 +0000
bugs1426719, 17063
milestone59.0a1
Bug 1426719 - Workaround a bug in Windows Insider build 17063 which breaks sound in Firefox. MozReview-Commit-ID: Csq0i2DvFnx
media/libcubeb/src/cubeb_wasapi.cpp
--- a/media/libcubeb/src/cubeb_wasapi.cpp
+++ b/media/libcubeb/src/cubeb_wasapi.cpp
@@ -1153,17 +1153,17 @@ stream_set_volume(cubeb_stream * stm, fl
   }
 
   float volumes[10];
   for (uint32_t i = 0; i < channels; i++) {
     volumes[i] = volume;
   }
 
   hr = stm->audio_stream_volume->SetAllVolumes(channels,  volumes);
-  if (hr != S_OK) {
+  if (FAILED(hr)) {
     LOG("could not set the channels volume: %lx", hr);
     return CUBEB_ERROR;
   }
 
   return CUBEB_OK;
 }
 } // namespace anonymous