Bug 1426327 - Clean up PATH for mingw builds. r?gps draft
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 20 Dec 2017 17:59:16 +0900
changeset 713384 5a972de21ebf211a3543e8c3dec7bfce7679f8dd
parent 713183 2d580aeac901ce5c61a4e5445b46906ce3cf33d8
child 744329 231d9a3629f3e4074c09a619a033e2233a07d6dc
push id93638
push userbmo:mh+mozilla@glandium.org
push dateWed, 20 Dec 2017 09:19:58 +0000
reviewersgps
bugs1426327
milestone59.0a1
Bug 1426327 - Clean up PATH for mingw builds. r?gps The PATH defined for mingw builds was cargo culted, lacks /usr/local/bin, and contains things that are pretty much useless these days, now that we're off buildbot. Similarly, LD_LIBRARY_PATH is useless. While many other similar changes could be done to the other mozharness configurations, figuring out which ones are used under what circumstances is more work than I'm ready to put (I started, but I stopped when I encountered jobs that don't even run on try or central).
testing/mozharness/configs/builds/releng_base_windows_32_mingw_builds.py
--- a/testing/mozharness/configs/builds/releng_base_windows_32_mingw_builds.py
+++ b/testing/mozharness/configs/builds/releng_base_windows_32_mingw_builds.py
@@ -54,20 +54,17 @@ config = {
         'HG_SHARE_BASE_DIR': '/builds/hg-shared',
         'MOZ_OBJDIR': '%(abs_obj_dir)s',
         'TINDERBOX_OUTPUT': '1',
         'TOOLTOOL_CACHE': '/builds/worker/tooltool-cache',
         'TOOLTOOL_HOME': '/builds',
         'MOZ_CRASHREPORTER_NO_REPORT': '1',
         'LC_ALL': 'C',
         # 32 bit specific
-        'PATH': '/tools/buildbot/bin:/bin:/usr/bin:/usr/local/sbin:\
-/usr/sbin:/sbin:/tools/git/bin:/tools/python27/bin:\
-/tools/python27-mercurial/bin:/home/cltbld/bin',
-        'LD_LIBRARY_PATH': "/tools/gcc-4.3.3/installed/lib",
+        'PATH': '/usr/local/bin:/bin:/usr/bin',
     },
     'upload_env': {
         # stage_server is dictated from build_pool_specifics.py
         'UPLOAD_HOST': '%(stage_server)s',
         'UPLOAD_USER': '%(stage_username)s',
         'UPLOAD_SSH_KEY': '/home/mock_mozilla/.ssh/%(stage_ssh_key)s',
         'UPLOAD_TO_TEMP': '1',
     },