bug 1425985 - fix fennec post-beetmover-dummy. r=bhearsum draft
authorAki Sasaki <asasaki@mozilla.com>
Mon, 18 Dec 2017 15:35:23 -0800
changeset 712907 86bac9b8ea39a7a7e4d9ac9586ec4e22d3d48bde
parent 712875 f422c00dffd63a9f8f1464a41e027a542e7d0d66
child 744184 4aa2576ddd6566fe3062f6c032c37aab13eedefb
push id93479
push userasasaki@mozilla.com
push dateTue, 19 Dec 2017 02:46:41 +0000
reviewersbhearsum
bugs1425985
milestone59.0a1
bug 1425985 - fix fennec post-beetmover-dummy. r=bhearsum Adjust post-beetmover-dummy's tasks and deps. - Fennec doesn't have beetmover-repackage or beetmover-checksums, so add `beetmover` to the post-beetmover-dummy kind-dependencies. - Add a fennec-promote post-beetmover-dummy job. - Remove the extraneous -ship post-beetmover-dummy jobs. Once we removed the assumption that dummy jobs had to be in the same phase, these became redundant. In testing, this looks good. For the next step, we may want to split these dummy tasks up by `build_platform`. Then downstream tasks could then optionally filter their dummy deps by `build_platform`; this would allow for certain platforms to proceed on to the next steps sooner, rather than wait for the slowest platform to finish. I also suspect we don't need post-beetmover-checksums-dummy at all; it's redundant. MozReview-Commit-ID: EeHjwTQnVB1
taskcluster/ci/post-beetmover-dummy/kind.yml
--- a/taskcluster/ci/post-beetmover-dummy/kind.yml
+++ b/taskcluster/ci/post-beetmover-dummy/kind.yml
@@ -6,35 +6,21 @@ loader: taskgraph.loader.transform:loade
 
 transforms:
    - taskgraph.transforms.reverse_chunk_deps:transforms
    - taskgraph.transforms.task:transforms
 
 kind-dependencies:
    - beetmover-checksums
    - beetmover-repackage
+   # Fennec doesn't have beetmover-{checksums,repackage}, so
+   # also depend on vanilla beetmover.
+   - beetmover
 
 jobs:
-   firefox-ship:
-      name: post-beetmover-dummy
-      description: Dummy task to deal with max_dependencies
-      run-on-projects: []
-      shipping-phase: ship
-      shipping-product: firefox
-      worker-type: aws-provisioner-v1/gecko-{level}-b-linux
-      worker:
-         implementation: docker-worker
-         os: linux
-         docker-image: "ubuntu:16.10"
-         max-run-time: 600
-         command:
-            - /bin/bash
-            - -c
-            - echo "Dummy task"
-
    firefox-promote:
       name: post-beetmover-dummy
       description: Dummy task to deal with max_dependencies
       run-on-projects: []
       shipping-phase: promote
       shipping-product: firefox
       worker-type: aws-provisioner-v1/gecko-{level}-b-linux
       worker:
@@ -42,41 +28,41 @@ jobs:
          os: linux
          docker-image: "ubuntu:16.10"
          max-run-time: 600
          command:
             - /bin/bash
             - -c
             - echo "Dummy task"
 
-   devedition-ship:
-      name: post-beetmover-dummy
-      description: Dummy task to deal with max_dependencies
-      run-on-projects: []
-      shipping-phase: ship
-      shipping-product: devedition
-      worker-type: aws-provisioner-v1/gecko-{level}-b-linux
-      worker:
-         implementation: docker-worker
-         os: linux
-         docker-image: "ubuntu:16.10"
-         max-run-time: 600
-         command:
-            - /bin/bash
-            - -c
-            - echo "Dummy task"
-
    devedition-promote:
       name: post-beetmover-dummy
       description: Dummy task to deal with max_dependencies
       run-on-projects: []
       shipping-phase: promote
       shipping-product: devedition
       worker-type: aws-provisioner-v1/gecko-{level}-b-linux
       worker:
          implementation: docker-worker
          os: linux
          docker-image: "ubuntu:16.10"
          max-run-time: 600
          command:
             - /bin/bash
             - -c
             - echo "Dummy task"
+
+   fennec-promote:
+      name: post-beetmover-dummy
+      description: Dummy task to deal with max_dependencies
+      run-on-projects: []
+      shipping-phase: promote
+      shipping-product: fennec
+      worker-type: aws-provisioner-v1/gecko-{level}-b-linux
+      worker:
+         implementation: docker-worker
+         os: linux
+         docker-image: "ubuntu:16.10"
+         max-run-time: 600
+         command:
+            - /bin/bash
+            - -c
+            - echo "Dummy task"