Bug 1420706: Remove obsolete gconf work-around. draft
authorTom Prince <mozilla@hocat.ca>
Mon, 18 Dec 2017 10:24:37 -0700
changeset 23519 c7d9a51d09f37b49be92fdbd62c8a0cf96cc11f4
parent 23518 b045d93bbd539474f6c9ded13bd993ba2f3e4c07
push id179
push userbmo:mozilla@hocat.ca
push dateMon, 18 Dec 2017 18:26:45 +0000
bugs1420706, 628204
Bug 1420706: Remove obsolete gconf work-around. The check was added https://bugzilla.mozilla.org/show_bug.cgi?id=628204#c8 without discussion or motivation, other than making the test pass. I suspect it was to work around a bug with the gconf support in gecko, which has probably since been fixed or made irrelevant. MozReview-Commit-ID: LtrNU9Onv0c
mail/components/test/unit/test_about_support.js
--- a/mail/components/test/unit/test_about_support.js
+++ b/mail/components/test/unit/test_about_support.js
@@ -178,21 +178,15 @@ function test_get_account_details() {
 }
 
 var tests = [
   test_get_file_system_type,
   test_get_account_details,
 ];
 
 function run_test() {
-  if ("@mozilla.org/gnome-gconf-service;1" in Cc) {
-    // The GNOME GConf service needs to be initialized, otherwise we get
-    // assertions about g_type_init not being called.
-    Cc["@mozilla.org/gnome-gconf-service;1"].getService();
-  }
-
   Services.scriptloader.loadSubScript("chrome://messenger/content/about-support/accounts.js");
 
   setup_accounts();
 
   for (let test of tests)
     test();
 }