Bug 1424162: Put the filter bar before the console output in the web console. r?nchevobbe draft
authorJames Teh <jteh@mozilla.com>
Fri, 15 Dec 2017 15:15:05 -0600
changeset 712289 83e6d7a181782fdc5e1669fd8957274e29d8103a
parent 711692 8062887ff0d9382ea84177f2c21f62dc0e613d9e
child 744019 5686fc540eea197e2fc8b927244e9eecb26d2ce3
push id93298
push userbmo:jteh@mozilla.com
push dateFri, 15 Dec 2017 21:54:57 +0000
reviewersnchevobbe
bugs1424162
milestone59.0a1
Bug 1424162: Put the filter bar before the console output in the web console. r?nchevobbe The filter bar was already positioned before the console output visually. However, accessibility clients such as screen readers rely on the semantic order, not the visual order, for positioning of content. This makes it easier for screen reader users to quickly get to the bottom of the console output, which is important for efficiency when reading recent output. MozReview-Commit-ID: Ae8z6H1k9np
devtools/client/webconsole/new-console-output/new-console-output-wrapper.js
--- a/devtools/client/webconsole/new-console-output/new-console-output-wrapper.js
+++ b/devtools/client/webconsole/new-console-output/new-console-output-wrapper.js
@@ -194,18 +194,18 @@ NewConsoleOutputWrapper.prototype = {
         serviceContainer,
       });
 
       let provider = createElement(
         Provider,
         { store },
         dom.div(
           {className: "webconsole-output-wrapper"},
+          filterBar,
           consoleOutput,
-          filterBar,
           sideBar
         ));
       this.body = ReactDOM.render(provider, this.parentNode);
 
       this.jsterm.focus();
     });
   },