Bug 1424690 - Fix message expanding; r=nchevobbe draft
authorJan Odvarko <odvarko@gmail.com>
Mon, 11 Dec 2017 10:42:24 +0100
changeset 714075 36f78343dc679be6f77a6ffcf73419df51d84606
parent 713529 2ff08db67b917fba1558986f3f2f796260f970f8
child 714076 a964e620cd4bde86c4ae90e6d54377dbf253bd0c
child 714085 552fadd656023c18d6e3802275c49cec08eb04ba
child 714086 56d74cc6969c942d471e6f467e98a6064fe72d24
child 714122 d6f68715665d92511d33d0cd65faa60c547441ff
push id93839
push userbmo:abhinav.koppula@gmail.com
push dateThu, 21 Dec 2017 17:26:40 +0000
reviewersnchevobbe
bugs1424690
milestone59.0a1
Bug 1424690 - Fix message expanding; r=nchevobbe MozReview-Commit-ID: EeHZXmGtCwX
devtools/client/webconsole/new-console-output/reducers/messages.js
--- a/devtools/client/webconsole/new-console-output/reducers/messages.js
+++ b/devtools/client/webconsole/new-console-output/reducers/messages.js
@@ -248,17 +248,18 @@ function messages(state = MessageState()
           });
       }
       return openState;
 
     case constants.MESSAGE_CLOSE:
       const closeState = {...state};
       let messageId = action.id;
       let index = closeState.messagesUiById.indexOf(messageId);
-      closeState.messagesUiById = [...closeState.messagesUiById].splice(index, 1);
+      closeState.messagesUiById.splice(index, 1);
+      closeState.messagesUiById = [...closeState.messagesUiById];
 
       // If the message is a group
       if (isGroupType(messagesById.get(messageId).type)) {
         // Hide all its children
         closeState.visibleMessages = visibleMessages.filter(id =>
           getParentGroups(messagesById.get(id).groupId, groupsById)
             .includes(messageId) === false
         );