Bug 1425209 - remove dead code in CompileSimpleQuery. r?bz draft
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Thu, 14 Dec 2017 13:17:34 +0200
changeset 711693 5182eb1ef7801b7fdb52f720d48ff7a29b9b3771
parent 711692 8062887ff0d9382ea84177f2c21f62dc0e613d9e
child 743838 908dbf374cee09f6147a83dac0a88218b59bcde5
push id93102
push userbmo:bpostelnicu@mozilla.com
push dateThu, 14 Dec 2017 11:18:12 +0000
reviewersbz
bugs1425209
milestone59.0a1
Bug 1425209 - remove dead code in CompileSimpleQuery. r?bz MozReview-Commit-ID: 3cJAjSC47zT
dom/xul/templates/nsXULTemplateQueryProcessorRDF.cpp
--- a/dom/xul/templates/nsXULTemplateQueryProcessorRDF.cpp
+++ b/dom/xul/templates/nsXULTemplateQueryProcessorRDF.cpp
@@ -1490,18 +1490,16 @@ nsXULTemplateQueryProcessorRDF::CompileS
     TestNode* parentNode;
 
     if (! mSimpleRuleMemberTest) {
         rv = AddDefaultSimpleRules(aQuery, &parentNode);
         if (NS_FAILED(rv))
             return rv;
     }
 
-    bool hasContainerTest = false;
-
     TestNode* prevnode = mSimpleRuleMemberTest;
 
     // Add constraints for the LHS
     const nsAttrName* name;
     for (uint32_t i = 0; (name = aQueryElement->GetAttrNameAt(i)); ++i) {
         // Note: some attributes must be skipped on XUL template query subtree
 
         // never compare against rdf:property, rdf:instanceOf, {}:id or {}:parsetype attribute
@@ -1519,21 +1517,16 @@ nsXULTemplateQueryProcessorRDF::CompileS
 
         nsAutoString value;
         aQueryElement->GetAttr(attrNameSpaceID, attr, value);
 
         TestNode* testnode = nullptr;
 
         if (name->Equals(nsGkAtoms::iscontainer, kNameSpaceID_None) ||
             name->Equals(nsGkAtoms::isempty, kNameSpaceID_None)) {
-            // Tests about containerhood and emptiness. These can be
-            // globbed together, mostly. Check to see if we've already
-            // added a container test: we only need one.
-            if (hasContainerTest)
-                continue;
 
             nsRDFConInstanceTestNode::Test iscontainer =
                 nsRDFConInstanceTestNode::eDontCare;
 
             static nsIContent::AttrValuesArray strings[] =
               {&nsGkAtoms::_true, &nsGkAtoms::_false, nullptr};
             switch (aQueryElement->FindAttrValueIn(kNameSpaceID_None,
                                                    nsGkAtoms::iscontainer,