Bug 1424875 - pass aPlace as const& in NotifyManyVisitsObservers and NotifyVisit. r?mak draft
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Tue, 12 Dec 2017 17:01:35 +0200
changeset 710876 b310678a58518be305713fa0fbbe77c02d939512
parent 710859 a16f868d488b41c6871c705b0a15c1b5b3deb4ce
child 743674 044bef76c4685f9a36375a384efdb5ff0b6ad56e
push id92924
push userbmo:bpostelnicu@mozilla.com
push dateTue, 12 Dec 2017 15:02:41 +0000
reviewersmak
bugs1424875
milestone59.0a1
Bug 1424875 - pass aPlace as const& in NotifyManyVisitsObservers and NotifyVisit. r?mak MozReview-Commit-ID: 21LfMFYtOXS
toolkit/components/places/History.cpp
--- a/toolkit/components/places/History.cpp
+++ b/toolkit/components/places/History.cpp
@@ -621,34 +621,34 @@ NS_IMPL_ISUPPORTS_INHERITED(
 )
 
 /**
  * Notifies observers about a visit or an array of visits.
  */
 class NotifyManyVisitsObservers : public Runnable
 {
 public:
-  explicit NotifyManyVisitsObservers(VisitData aPlace)
+  explicit NotifyManyVisitsObservers(const VisitData& aPlace)
     : Runnable("places::NotifyManyVisitsObservers")
     , mPlace(aPlace)
     , mHistory(History::GetService())
   {
   }
 
   explicit NotifyManyVisitsObservers(nsTArray<VisitData>& aPlaces)
     : Runnable("places::NotifyManyVisitsObservers")
     , mHistory(History::GetService())
   {
     aPlaces.SwapElements(mPlaces);
   }
 
   nsresult NotifyVisit(nsNavHistory* aNavHistory,
                        nsCOMPtr<nsIObserverService>& aObsService,
                        PRTime aNow,
-                       VisitData aPlace) {
+                       const VisitData& aPlace) {
     nsCOMPtr<nsIURI> uri;
     MOZ_ALWAYS_SUCCEEDS(NS_NewURI(getter_AddRefs(uri), aPlace.spec));
     if (!uri) {
       return NS_ERROR_UNEXPECTED;
     }
     // Notify the visit.  Note that TRANSITION_EMBED visits are never added
     // to the database, thus cannot be queried and we don't notify them.
     if (aPlace.transitionType != nsINavHistoryService::TRANSITION_EMBED) {