Bug 1424690 - Fix message expanding; r=nchevobbe draft
authorJan Odvarko <odvarko@gmail.com>
Mon, 11 Dec 2017 10:42:24 +0100
changeset 710635 6275416c4742f249032e41d0ee04c4eae2468026
parent 710528 52fbf40d3e7d0ee443fe8ee3c0d360c2ce87d2ce
child 743619 93c8775619346687a9b50e43a4dde962f3873580
push id92865
push userbmo:odvarko@gmail.com
push dateMon, 11 Dec 2017 09:46:42 +0000
reviewersnchevobbe
bugs1424690
milestone59.0a1
Bug 1424690 - Fix message expanding; r=nchevobbe MozReview-Commit-ID: EeHZXmGtCwX
devtools/client/webconsole/new-console-output/reducers/messages.js
--- a/devtools/client/webconsole/new-console-output/reducers/messages.js
+++ b/devtools/client/webconsole/new-console-output/reducers/messages.js
@@ -248,17 +248,18 @@ function messages(state = MessageState()
           });
       }
       return openState;
 
     case constants.MESSAGE_CLOSE:
       const closeState = {...state};
       let messageId = action.id;
       let index = closeState.messagesUiById.indexOf(messageId);
-      closeState.messagesUiById = [...closeState.messagesUiById].splice(index, 1);
+      closeState.messagesUiById.splice(index, 1);
+      closeState.messagesUiById = [...closeState.messagesUiById];
 
       // If the message is a group
       if (isGroupType(messagesById.get(messageId).type)) {
         // Hide all its children
         closeState.visibleMessages = visibleMessages.filter(id =>
           getParentGroups(messagesById.get(id).groupId, groupsById)
             .includes(messageId) === false
         );