Bug 1422198 - Log about failure to send a sandbox broker reply. r?gcp draft
authorJed Davis <jld@xlerb.net>
Fri, 08 Dec 2017 14:43:36 -0700
changeset 710248 e981784fa6b5e989883184f5814d174b45555f40
parent 708361 dff2f7200586a6b5967d0d7b15bd64be41abeb19
child 743556 9a235688369eae9d7d2e0a185f22684dd1c21f3f
push id92794
push userbmo:jld@mozilla.com
push dateSat, 09 Dec 2017 00:43:02 +0000
reviewersgcp
bugs1422198
milestone59.0a1
Bug 1422198 - Log about failure to send a sandbox broker reply. r?gcp MozReview-Commit-ID: eDcoMHGFxo
security/sandbox/linux/broker/SandboxBroker.cpp
--- a/security/sandbox/linux/broker/SandboxBroker.cpp
+++ b/security/sandbox/linux/broker/SandboxBroker.cpp
@@ -879,17 +879,21 @@ SandboxBroker::ThreadMain(void)
         break;
       }
     } else {
       MOZ_ASSERT(perms == 0);
       AuditDenial(req.mOp, req.mFlags, perms, pathBuf);
     }
 
     const size_t numIO = ios[1].iov_len > 0 ? 2 : 1;
-    DebugOnly<const ssize_t> sent = SendWithFd(respfd, ios, numIO, openedFd);
+    const ssize_t sent = SendWithFd(respfd, ios, numIO, openedFd);
+    if (sent < 0) {
+      SANDBOX_LOG_ERROR("failed to send broker response to pid %d: %s", mChildPid,
+                        strerror(errno));
+    }
     close(respfd);
     MOZ_ASSERT(sent < 0 ||
                static_cast<size_t>(sent) == ios[0].iov_len + ios[1].iov_len);
 
     if (openedFd >= 0) {
       close(openedFd);
     }
   }