Bug 1424294 - Also manage spaces in filename in tools/update-packaging/common.sh r?bhearsum draft
authorSylvestre Ledru <sledru@mozilla.com>
Fri, 08 Dec 2017 15:21:07 +0100
changeset 709718 22428ed09798134f0cbc77ce74330cec2e7eddd6
parent 709658 b2f7c1785b5c452c419117818e08f85a48a05a54
child 712976 5ecb0304cd3b7fe3358616fea795e08c0fd7c30b
push id92730
push userbmo:sledru@mozilla.com
push dateFri, 08 Dec 2017 16:59:26 +0000
reviewersbhearsum
bugs1424294
milestone59.0a1
Bug 1424294 - Also manage spaces in filename in tools/update-packaging/common.sh r?bhearsum MozReview-Commit-ID: 4hrr59gEeEM
tools/update-packaging/common.sh
--- a/tools/update-packaging/common.sh
+++ b/tools/update-packaging/common.sh
@@ -85,17 +85,17 @@ make_add_instruction() {
     notice "     add-if \"$testdir\" \"$f\""
     echo "add-if \"$testdir\" \"$f\"" >> "$filev2"
     if [ ! $filev3 = "" ]; then
       echo "add-if \"$testdir\" \"$f\"" >> "$filev3"
     fi
   else
     notice "        add \"$f\"$forced"
     echo "add \"$f\"" >> "$filev2"
-    if [ ! $filev3 = "" ]; then
+    if [ ! "$filev3" = "" ]; then
       echo "add \"$f\"" >> "$filev3"
     fi
   fi
 }
 
 check_for_add_if_not_update() {
   add_if_not_file_chk="$1"
 
@@ -119,17 +119,17 @@ check_for_add_to_manifestv2() {
   return 1;
 }
 
 make_add_if_not_instruction() {
   f="$1"
   filev3="$2"
 
   notice " add-if-not \"$f\" \"$f\""
-  echo "add-if-not \"$f\" \"$f\"" >> $filev3
+  echo "add-if-not \"$f\" \"$f\"" >> "$filev3"
 }
 
 make_patch_instruction() {
   f="$1"
   filev2="$2"
   filev3="$3"
 
   is_extension=$(echo "$f" | grep -c 'distribution/extensions/.*/')