Bug 1423891 - Panel header is gone when going back from Bookmarks to Library. r=Gijs draft
authorPaolo Amadini <paolo.mozmail@amadzone.org>
Thu, 07 Dec 2017 14:24:12 +0000
changeset 709042 012dd324aa02990dab3c99d6cb941fe027e59d27
parent 709000 ba84e01c50eed07f85e3ced37eaaf134843e2a6a
child 743312 4af8459df679550071ebda4c7c4584b0442966e0
push id92523
push userpaolo.mozmail@amadzone.org
push dateThu, 07 Dec 2017 14:26:23 +0000
reviewersGijs
bugs1423891
milestone59.0a1
Bug 1423891 - Panel header is gone when going back from Bookmarks to Library. r=Gijs MozReview-Commit-ID: Bfgg61BH9L8
browser/components/customizableui/PanelMultiView.jsm
--- a/browser/components/customizableui/PanelMultiView.jsm
+++ b/browser/components/customizableui/PanelMultiView.jsm
@@ -489,21 +489,24 @@ this.PanelMultiView = class {
           this._placeSubView(viewNode);
         } else {
           throw new Error(`Subview ${aViewId} doesn't exist!`);
         }
       } else if (viewNode.parentNode == this._panelViewCache) {
         this._placeSubView(viewNode);
       }
 
+      let reverse = !!aPreviousView;
+
       viewNode.panelMultiView = this.node;
-      this._setHeader(viewNode, viewNode.getAttribute("title") ||
-                                (aAnchor && aAnchor.getAttribute("label")));
+      if (!reverse) {
+        this._setHeader(viewNode, viewNode.getAttribute("title") ||
+                                  (aAnchor && aAnchor.getAttribute("label")));
+      }
 
-      let reverse = !!aPreviousView;
       let previousViewNode = aPreviousView || this._currentSubView;
       // If the panelview to show is the same as the previous one, the 'ViewShowing'
       // event has already been dispatched. Don't do it twice.
       let showingSameView = viewNode == previousViewNode;
       let playTransition = (!!previousViewNode && !showingSameView && this._panel.state == "open");
       let isMainView = viewNode.id == this._mainViewId;
 
       let dwu = this._dwu;