Bug 1419401 - show HTTP/2.0 200 OK in raw header;r=honza
MozReview-Commit-ID: 7ApdEDofYwJ
--- a/devtools/client/netmonitor/src/components/HeadersPanel.js
+++ b/devtools/client/netmonitor/src/components/HeadersPanel.js
@@ -253,33 +253,35 @@ class HeadersPanel extends Component {
onClick: this.toggleRawHeaders,
}, RAW_HEADERS),
)
);
}
let summaryVersion = httpVersion ?
this.renderSummary(SUMMARY_VERSION, httpVersion) : null;
+ // display Status-Line above other response headers
+ let statusLine = `${httpVersion} ${status} ${statusText}\n`;
let summaryRawHeaders;
if (this.state.rawHeadersOpened) {
summaryRawHeaders = (
div({ className: "tabpanel-summary-container headers-summary" },
div({ className: "raw-headers-container" },
div({ className: "raw-headers" },
div({ className: "tabpanel-summary-label" }, RAW_HEADERS_REQUEST),
textarea({
value: writeHeaderText(requestHeaders.headers),
readOnly: true,
}),
),
div({ className: "raw-headers" },
div({ className: "tabpanel-summary-label" }, RAW_HEADERS_RESPONSE),
textarea({
- value: writeHeaderText(responseHeaders.headers),
+ value: statusLine + writeHeaderText(responseHeaders.headers),
readOnly: true,
}),
),
)
)
);
}
--- a/devtools/client/netmonitor/test/browser_net_headers_sorted.js
+++ b/devtools/client/netmonitor/test/browser_net_headers_sorted.js
@@ -32,21 +32,22 @@ add_task(function* () {
let expectedRequestHeaders = ["Accept", "Accept-Encoding", "Accept-Language",
"Cache-Control", "Connection", "Cookie", "Host",
"Pragma", "Upgrade-Insecure-Requests", "User-Agent"];
let labelCells = document.querySelectorAll(".treeLabelCell");
let actualResponseHeaders = [];
let actualRequestHeaders = [];
- for (let i = 1; i < 11; i++) {
+ let responseHeadersLength = expectedResponseHeaders.length;
+ for (let i = 1; i < responseHeadersLength + 1; i++) {
actualResponseHeaders.push(labelCells[i].innerText);
}
- for (let i = 12; i < labelCells.length; i++) {
+ for (let i = responseHeadersLength + 2; i < labelCells.length; i++) {
actualRequestHeaders.push(labelCells[i].innerText);
}
is(actualResponseHeaders.toString(), expectedResponseHeaders.toString(),
"Response Headers are sorted");
is(actualRequestHeaders.toString(), expectedRequestHeaders.toString(),
"Request Headers are sorted");