Bug 1419401 - show HTTP/2.0 200 OK in raw header;r=honza draft
authorFred Lin <gasolin@gmail.com>
Thu, 07 Dec 2017 16:22:55 +0800
changeset 709151 54b02290df18ce98dcf4d82cd7b23b344b3c570a
parent 708706 4b94da21a9e6171f9911ffad171af23c26e6227b
child 743338 998f1e71c979e22378a28b2af6fe59db4f6df245
push id92551
push userbmo:gasolin@mozilla.com
push dateThu, 07 Dec 2017 17:17:16 +0000
reviewershonza
bugs1419401
milestone59.0a1
Bug 1419401 - show HTTP/2.0 200 OK in raw header;r=honza MozReview-Commit-ID: 7ApdEDofYwJ
devtools/client/netmonitor/src/components/HeadersPanel.js
devtools/client/netmonitor/test/browser_net_headers_sorted.js
--- a/devtools/client/netmonitor/src/components/HeadersPanel.js
+++ b/devtools/client/netmonitor/src/components/HeadersPanel.js
@@ -253,33 +253,35 @@ class HeadersPanel extends Component {
             onClick: this.toggleRawHeaders,
           }, RAW_HEADERS),
         )
       );
     }
 
     let summaryVersion = httpVersion ?
       this.renderSummary(SUMMARY_VERSION, httpVersion) : null;
+    // display Status-Line above other response headers
+    let statusLine = `${httpVersion} ${status} ${statusText}\n`;
 
     let summaryRawHeaders;
     if (this.state.rawHeadersOpened) {
       summaryRawHeaders = (
         div({ className: "tabpanel-summary-container headers-summary" },
           div({ className: "raw-headers-container" },
             div({ className: "raw-headers" },
               div({ className: "tabpanel-summary-label" }, RAW_HEADERS_REQUEST),
               textarea({
                 value: writeHeaderText(requestHeaders.headers),
                 readOnly: true,
               }),
             ),
             div({ className: "raw-headers" },
               div({ className: "tabpanel-summary-label" }, RAW_HEADERS_RESPONSE),
               textarea({
-                value: writeHeaderText(responseHeaders.headers),
+                value: statusLine + writeHeaderText(responseHeaders.headers),
                 readOnly: true,
               }),
             ),
           )
         )
       );
     }
 
--- a/devtools/client/netmonitor/test/browser_net_headers_sorted.js
+++ b/devtools/client/netmonitor/test/browser_net_headers_sorted.js
@@ -32,21 +32,22 @@ add_task(function* () {
   let expectedRequestHeaders = ["Accept", "Accept-Encoding", "Accept-Language",
                                 "Cache-Control", "Connection", "Cookie", "Host",
                                 "Pragma", "Upgrade-Insecure-Requests", "User-Agent"];
 
   let labelCells = document.querySelectorAll(".treeLabelCell");
   let actualResponseHeaders = [];
   let actualRequestHeaders = [];
 
-  for (let i = 1; i < 11; i++) {
+  let responseHeadersLength = expectedResponseHeaders.length;
+  for (let i = 1; i < responseHeadersLength + 1; i++) {
     actualResponseHeaders.push(labelCells[i].innerText);
   }
 
-  for (let i = 12; i < labelCells.length; i++) {
+  for (let i = responseHeadersLength + 2; i < labelCells.length; i++) {
     actualRequestHeaders.push(labelCells[i].innerText);
   }
 
   is(actualResponseHeaders.toString(), expectedResponseHeaders.toString(),
     "Response Headers are sorted");
 
   is(actualRequestHeaders.toString(), expectedRequestHeaders.toString(),
     "Request Headers are sorted");