Bug 1423612 - Pass VisitData by reference r=standard8
Fairly trivial. Prompted by a coverity report.
MozReview-Commit-ID: 8Yg5KsRc2E1
--- a/toolkit/components/places/History.cpp
+++ b/toolkit/components/places/History.cpp
@@ -626,17 +626,17 @@ NS_IMPL_ISUPPORTS_INHERITED(
)
/**
* Notifies observers about a visit or an array of visits.
*/
class NotifyManyVisitsObservers : public Runnable
{
public:
- explicit NotifyManyVisitsObservers(VisitData aPlace)
+ explicit NotifyManyVisitsObservers(const VisitData& aPlace)
: Runnable("places::NotifyManyVisitsObservers")
, mPlace(aPlace)
, mHistory(History::GetService())
{
}
explicit NotifyManyVisitsObservers(nsTArray<VisitData>& aPlaces)
: Runnable("places::NotifyManyVisitsObservers")
@@ -644,17 +644,17 @@ public:
{
aPlaces.SwapElements(mPlaces);
}
nsresult NotifyVisit(nsNavHistory* aNavHistory,
nsCOMPtr<nsIObserverService>& aObsService,
PRTime aNow,
nsTArray<URIParams>& aNotifyVisitedURIs,
- VisitData aPlace) {
+ const VisitData& aPlace) {
nsCOMPtr<nsIURI> uri;
MOZ_ALWAYS_SUCCEEDS(NS_NewURI(getter_AddRefs(uri), aPlace.spec));
if (!uri) {
return NS_ERROR_UNEXPECTED;
}
// Notify the visit. Note that TRANSITION_EMBED visits are never added
// to the database, thus cannot be queried and we don't notify them.
if (aPlace.transitionType != nsINavHistoryService::TRANSITION_EMBED) {