Bug 1263313 Switch search to AMO draft
authorAndrew Swan <aswan@mozilla.com>
Tue, 05 Dec 2017 21:07:09 -0800
changeset 710009 e0b8db0851664249ef49f25bca73f43b3a022922
parent 710008 d927d38c64cb87a91b3ca65c833766b5b8afbdec
child 710010 366ae12a5892ef3865343304196726f14ad818be
push id92738
push useraswan@mozilla.com
push dateFri, 08 Dec 2017 17:56:08 +0000
bugs1263313
milestone59.0a1
Bug 1263313 Switch search to AMO MozReview-Commit-ID: 6FO2dgI5WdH
toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd
toolkit/mozapps/extensions/content/extensions.js
toolkit/mozapps/extensions/content/extensions.xul
--- a/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd
+++ b/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd
@@ -1,14 +1,14 @@
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <!ENTITY addons.windowTitle                   "Add-ons Manager">
 
-<!ENTITY search.placeholder                   "Search all add-ons">
+<!ENTITY search.placeholder2                  "Search on addons.mozilla.org">
 <!ENTITY search.buttonlabel                   "Search">
 <!-- LOCALIZATION NOTE (search.commandKey):
      The search command key should match findOnCmd.commandkey from browser.dtd -->
 <!ENTITY search.commandkey                    "f">
 
 <!ENTITY loading.label                        "Loading…">
 <!ENTITY listEmpty.installed.label            "You don’t have any add-ons of this type installed">
 <!ENTITY listEmpty.availableUpdates.label     "No updates found">
--- a/toolkit/mozapps/extensions/content/extensions.js
+++ b/toolkit/mozapps/extensions/content/extensions.js
@@ -2045,17 +2045,21 @@ var gHeader = {
   initialize() {
     this._search = document.getElementById("header-search");
 
     this._search.addEventListener("command", function(aEvent) {
       var query = aEvent.target.value;
       if (query.length == 0)
         return;
 
-      gViewController.loadView("addons://search/" + encodeURIComponent(query));
+      let url = AddonRepository.getSearchURL(query);
+
+      let browser = getBrowserElement();
+      let chromewin = browser.ownerGlobal;
+      chromewin.openLinkIn(url, "tab", {fromChrome: true});
     });
   },
 
   focusSearchBox() {
     this._search.focus();
   },
 
   onKeyPress(aEvent) {
--- a/toolkit/mozapps/extensions/content/extensions.xul
+++ b/toolkit/mozapps/extensions/content/extensions.xul
@@ -251,17 +251,17 @@
                 <menuitem id="utils-resetAddonUpdatesToManual"
                           label="&updates.resetUpdatesToManual.label;"
                           accesskey="&updates.resetUpdatesToManual.accesskey;"
                           command="cmd_resetAddonAutoUpdate"/>
               </menupopup>
             </toolbarbutton>
             <textbox id="header-search" type="search" searchbutton="true"
                      searchbuttonlabel="&search.buttonlabel;"
-                     placeholder="&search.placeholder;"/>
+                     placeholder="&search.placeholder2;"/>
           </hbox>
 
           <deck id="headered-views-content" flex="1" selectedIndex="0">
             <!-- search view -->
             <vbox id="search-view" flex="1" class="view-pane" tabindex="0">
               <hbox class="view-header global-warning-container" align="center">
                 <!-- global warnings -->
                 <hbox class="global-warning" flex="1">