Bug 1423465. P6 - assert some MediaCacheStream functions are run off the main thread. draft
authorJW Wang <jwwang@mozilla.com>
Tue, 05 Dec 2017 15:23:43 +0800
changeset 708110 b30eea4d6dac1972a4f9cc0a6ee2275fc23965f1
parent 708109 1ce503c3d9ef89c6250f9e6877dce3213ccb7427
child 708111 c011ea19032868ddecf05ac0f82020fe279f9c98
child 709420 d30b8eac49a7c5e3e5f355dc3e33c71bfa40a77f
push id92287
push userjwwang@mozilla.com
push dateWed, 06 Dec 2017 07:32:57 +0000
bugs1423465
milestone59.0a1
Bug 1423465. P6 - assert some MediaCacheStream functions are run off the main thread. MozReview-Commit-ID: I0GWj6I82Iv
dom/media/MediaCache.cpp
--- a/dom/media/MediaCache.cpp
+++ b/dom/media/MediaCache.cpp
@@ -2431,17 +2431,17 @@ MediaCacheStream::GetNextCachedData(int6
   MOZ_ASSERT(!NS_IsMainThread());
   AutoLock lock(mMediaCache->Monitor());
   return GetNextCachedDataInternal(lock, aOffset);
 }
 
 int64_t
 MediaCacheStream::GetCachedDataEnd(int64_t aOffset)
 {
-  // TODO: Assert non-main thread.
+  MOZ_ASSERT(!NS_IsMainThread());
   AutoLock lock(mMediaCache->Monitor());
   return GetCachedDataEndInternal(lock, aOffset);
 }
 
 bool
 MediaCacheStream::IsDataCachedToEndOfStream(int64_t aOffset)
 {
   MOZ_ASSERT(!NS_IsMainThread());
@@ -2938,17 +2938,17 @@ nsresult MediaCacheStream::GetCachedRang
       "Must have advanced to start of next range, or hit end of stream");
   }
   return NS_OK;
 }
 
 double
 MediaCacheStream::GetDownloadRate(bool* aIsReliable)
 {
-  // TODO: Assert non-main thread.
+  MOZ_ASSERT(!NS_IsMainThread());
   AutoLock lock(mMediaCache->Monitor());
   return mDownloadStatistics.GetRate(aIsReliable);
 }
 
 nsCString
 MediaCacheStream::GetDebugInfo()
 {
   AutoLock lock(mMediaCache->Monitor());