Bug 1319222 - Remove INCLUDES from HOST_SIMPLE_PROGRAMS linking; r?chmanchester draft
authorMike Shal <mshal@mozilla.com>
Tue, 05 Dec 2017 10:36:15 -0500 (2017-12-05)
changeset 707635 c2f57f40a4a4ff329d784abbd4942c7193cc788a
parent 707634 a390faab307e201b73cce0070f07ba40f15b8ab6
child 707636 4e51e717bd72dfc992f8f51777a8f6aca344dc43
push id92183
push userbmo:mshal@mozilla.com
push dateTue, 05 Dec 2017 16:33:02 +0000 (2017-12-05)
reviewerschmanchester
bugs1319222, 59454
milestone59.0a1
Bug 1319222 - Remove INCLUDES from HOST_SIMPLE_PROGRAMS linking; r?chmanchester These flags were added way back in bug 59454 to both the compiling and linking rules for HOST_SIMPLE_PROGRAMS. However, the INCLUDES aren't actually needed when linking so we can safely remove them. MozReview-Commit-ID: 8QywO7tGPpU
config/rules.mk
--- a/config/rules.mk
+++ b/config/rules.mk
@@ -646,19 +646,19 @@ ifdef MOZ_POST_PROGRAM_COMMAND
 endif
 
 $(HOST_SIMPLE_PROGRAMS): host_%$(HOST_BIN_SUFFIX): host_%.$(OBJ_SUFFIX) $(HOST_LIBS) $(HOST_EXTRA_DEPS) $(GLOBAL_DEPS)
 	$(REPORT_BUILD)
 ifeq (WINNT_,$(HOST_OS_ARCH)_$(GNU_CC))
 	$(EXPAND_LIBS_EXEC) -- $(LINK) -NOLOGO -OUT:$@ -PDB:$(HOST_PDBFILE) $< $(WIN32_EXE_LDFLAGS) $(HOST_LIBS) $(HOST_EXTRA_LIBS)
 else
 ifneq (,$(HOST_CPPSRCS)$(USE_HOST_CXX))
-	$(EXPAND_LIBS_EXEC) -- $(HOST_CXX) $(HOST_OUTOPTION)$@ $(HOST_CXXFLAGS) $(INCLUDES) $< $(HOST_LIBS) $(HOST_EXTRA_LIBS)
+	$(EXPAND_LIBS_EXEC) -- $(HOST_CXX) $(HOST_OUTOPTION)$@ $(HOST_CXXFLAGS) $< $(HOST_LIBS) $(HOST_EXTRA_LIBS)
 else
-	$(EXPAND_LIBS_EXEC) -- $(HOST_CC) $(HOST_OUTOPTION)$@ $(HOST_CFLAGS) $(INCLUDES) $< $(HOST_LIBS) $(HOST_EXTRA_LIBS)
+	$(EXPAND_LIBS_EXEC) -- $(HOST_CC) $(HOST_OUTOPTION)$@ $(HOST_CFLAGS) $< $(HOST_LIBS) $(HOST_EXTRA_LIBS)
 endif
 endif
 ifndef CROSS_COMPILE
 	$(call CHECK_STDCXX,$@)
 endif
 
 $(filter %.$(LIB_SUFFIX),$(LIBRARY)): $(OBJS) $(STATIC_LIBS_DEPS) $(EXTRA_DEPS) $(GLOBAL_DEPS)
 	$(REPORT_BUILD)