Bug 1422915 - Be explicit about remote-active data when shutting down. r?whimboo draft
authorAndreas Tolfsen <ato@sny.no>
Mon, 04 Dec 2017 18:55:42 +0000
changeset 707019 dca81b9b157d2f5702d87155110c5dff5f3a0ad0
parent 707018 e3f95bcc4152c72ba864e14646317c899df38d50
child 742841 f013a0383935f3cf33f0ac520511cf15d923f917
push id92005
push userbmo:ato@sny.no
push dateMon, 04 Dec 2017 18:56:58 +0000
reviewerswhimboo
bugs1422915
milestone59.0a1
Bug 1422915 - Be explicit about remote-active data when shutting down. r?whimboo When Marionette starts and shuts down it emits the remote-active system notification. On starting the data is set to true (a boolean), but on shutdown it is left undefined which defaults to null. We should use false (boolean) explicitly. MozReview-Commit-ID: Er0Wn2pZrOi
testing/marionette/server.js
--- a/testing/marionette/server.js
+++ b/testing/marionette/server.js
@@ -383,17 +383,17 @@ server.TCPListener = class {
       logger.debug(`Resetting recommended pref ${k}`);
       Preferences.reset(k);
     }
     this.alteredPrefs.clear();
 
     // Shutdown server socket, and no longer listen for new connections
     this.acceptConnections = false;
 
-    Services.obs.notifyObservers(this, NOTIFY_RUNNING);
+    Services.obs.notifyObservers(this, NOTIFY_RUNNING, false);
     this.alive = false;
   }
 
   onSocketAccepted(serverSocket, clientSocket) {
     let input = clientSocket.openInputStream(0, 0, 0);
     let output = clientSocket.openOutputStream(0, 0, 0);
     let transport = new DebuggerTransport(input, output);