Bug 1413051 - fix aboutdebugging addon tip icon in RTL;r=ochameau draft
authorJulian Descottes <jdescottes@mozilla.com>
Mon, 04 Dec 2017 14:07:50 +0100
changeset 706928 7a59d3f888f888d220a7f0c469875bd61ae64e62
parent 706927 1585d679d1dfbe3ab16def8da586c41b4cb995b5
child 742797 3bf937164807bf52882d85fbafa85e28133a0a72
push id91957
push userjdescottes@mozilla.com
push dateMon, 04 Dec 2017 13:08:59 +0000
reviewersochameau
bugs1413051
milestone59.0a1
Bug 1413051 - fix aboutdebugging addon tip icon in RTL;r=ochameau MozReview-Commit-ID: 3aMuHiBHhVG
devtools/client/aboutdebugging/aboutdebugging.css
devtools/client/aboutdebugging/components/addons/Panel.js
--- a/devtools/client/aboutdebugging/aboutdebugging.css
+++ b/devtools/client/aboutdebugging/aboutdebugging.css
@@ -214,25 +214,26 @@ button {
   margin-inline-end: 1ch;
 }
 
 .addons-tip {
   display: flex;
   align-items: center;
   margin-top: 1em;
   margin-bottom: 1em;
-  background-image: url(chrome://devtools/skin/images/help.svg);
-  background-repeat: no-repeat;
-  background-size: 24px;
-  padding-inline-start: 32px;
   height: 24px;
 }
 
 .addons-tip-icon {
-  margin-inline-end: 1ch;
+  width: 24px;
+  height: 24px;
+  background-image: url(chrome://devtools/skin/images/help.svg);
+  background-repeat: no-repeat;
+  background-size: 24px;
+  margin-inline-end: 8px;
 }
 
 .error-page {
   display: flex;
   justify-content: center;
   align-items: center;
   flex-direction: column;
   width: 100%;
--- a/devtools/client/aboutdebugging/components/addons/Panel.js
+++ b/devtools/client/aboutdebugging/components/addons/Panel.js
@@ -166,16 +166,17 @@ class AddonsPanel extends Component {
         targets: temporaryTargets,
         client,
         connect,
         debugDisabled,
         targetClass,
         sort: true
       }),
       dom.div({ className: "addons-tip"},
+        dom.div({ className: "addons-tip-icon"}),
         dom.span({
           className: "addons-web-ext-tip",
         }, Strings.GetStringFromName("webExtTip")),
         dom.a({ href: WEB_EXT_URL, target: "_blank" },
           Strings.GetStringFromName("webExtTip.learnMore")
         )
       )
     ),