hooks: check reviewers case-independently (
bug 1422487), r?gps
MozReview-Commit-ID: KCaPyXc0mGQ
--- a/hghooks/mozhghooks/check/prevent_ftl_changes.py
+++ b/hghooks/mozhghooks/check/prevent_ftl_changes.py
@@ -57,17 +57,19 @@ class FTLCheck(PreTxnChangegroupCheck):
# Skip merge changesets
return True
if is_backout(ctx.description()):
# Ignore backouts
return True
if any(f.endswith('.ftl') for f in ctx.files()):
- requal = parse_requal_reviewers(ctx.description())
+ requal = [
+ r.lower() for r in parse_requal_reviewers(ctx.description())
+ ]
reviewers = [nick for (name, nick) in FTL_DRIVERS]
if any(nick in reviewers for nick in requal):
return True
print_banner(self.ui, 'error', FTL_COMMIT_FOUND)
return False
return True
--- a/hghooks/tests/test-prevent-ftl-changes.t
+++ b/hghooks/tests/test-prevent-ftl-changes.t
@@ -51,8 +51,20 @@ Commit adding an FTL file with appropria
$ hg -q commit -A -m 'add test2.ftl. r=someonelse,stas'
$ hg push
pushing to $TESTTMP/normal
searching for changes
adding changesets
adding manifests
adding file changes
added 1 changesets with 1 changes to 1 files
+
+Commit adding an FTL file with appropriate reviewer works, case-independent
+
+ $ touch test3.ftl
+ $ hg -q commit -A -m 'add test3.ftl. r=Pike'
+ $ hg push
+ pushing to $TESTTMP/normal
+ searching for changes
+ adding changesets
+ adding manifests
+ adding file changes
+ added 1 changesets with 1 changes to 1 files