Bug 1408935 - enable browser_webconsole_errors_after_page_reload.js;r=nchevobbe draft
authorJulian Descottes <jdescottes@mozilla.com>
Fri, 01 Dec 2017 18:15:37 +0100
changeset 706794 3bdd3d801641d3a1024434f72ef2f926277d19b4
parent 706271 5b85c8d3991ef95e59b48352e6080adf9e169090
child 742772 f2380d0696a20d953225af2f9b486f37c1278982
push id91931
push userjdescottes@mozilla.com
push dateMon, 04 Dec 2017 10:01:02 +0000
reviewersnchevobbe
bugs1408935
milestone59.0a1
Bug 1408935 - enable browser_webconsole_errors_after_page_reload.js;r=nchevobbe MozReview-Commit-ID: LMfIeeIy61Y
devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_errors_after_page_reload.js
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -269,17 +269,16 @@ skip-if = true # Bug 1408933
 # old console skip-if = os != "mac"
 [browser_webconsole_deactivateHUDForContext_unfocused_window.js]
 skip-if = true # Bug 1408934
 [browser_webconsole_document_focus.js]
 skip-if = true #	Bug 1404368
 [browser_webconsole_duplicate_errors.js]
 skip-if = true #	Bug 1403907
 [browser_webconsole_errors_after_page_reload.js]
-skip-if = true # Bug 1408935
 [browser_webconsole_eval_in_debugger_stackframe.js]
 skip-if = true # Bug 1408936
 [browser_webconsole_eval_in_debugger_stackframe2.js]
 skip-if = true # Bug 1408893
 [browser_webconsole_execution_scope.js]
 skip-if = true #	Bug 1405333
 [browser_webconsole_external_script_errors.js]
 [browser_webconsole_file_uri.js]
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_errors_after_page_reload.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_errors_after_page_reload.js
@@ -5,46 +5,33 @@
 
 // Tests that errors still show up in the Web Console after a page reload.
 // See bug 580030: the error handler fails silently after page reload.
 // https://bugzilla.mozilla.org/show_bug.cgi?id=580030
 
 "use strict";
 
 const TEST_URI = "http://example.com/browser/devtools/client/webconsole/" +
-                 "test/test-error.html";
+                 "new-console-output/test/mochitest/test-error.html";
 
-function test() {
-  Task.spawn(function* () {
-    const {tab} = yield loadTab(TEST_URI);
-    const hud = yield openConsole(tab);
-    info("console opened");
+add_task(async function () {
+  let hud = await openNewTabAndConsole(TEST_URI);
 
-    executeSoon(() => {
-      hud.jsterm.clearOutput();
-      info("wait for reload");
-      content.location.reload();
-    });
-
-    yield hud.target.once("navigate");
-    info("target navigated");
+  info("Reload the content window");
+  let onNavigate = hud.target.once("navigate");
+  ContentTask.spawn(gBrowser.selectedBrowser, null, () => {
+    content.wrappedJSObject.location.reload();
+  });
+  await onNavigate;
+  info("Target navigated");
 
-    let button = content.document.querySelector("button");
-    ok(button, "button found");
-
-    // On e10s, the exception is triggered in child process
-    // and is ignored by test harness
-    if (!Services.appinfo.browserTabsRemoteAutostart) {
-      expectUncaughtException();
-    }
-
-    EventUtils.sendMouseEvent({type: "click"}, button, content);
+  // On e10s, the exception is triggered in child process
+  // and is ignored by test harness
+  if (!Services.appinfo.browserTabsRemoteAutostart) {
+    expectUncaughtException();
+  }
 
-    yield waitForMessages({
-      webconsole: hud,
-      messages: [{
-        text: "fooBazBaz is not defined",
-        category: CATEGORY_JS,
-        severity: SEVERITY_ERROR,
-      }],
-    });
-  }).then(finishTest);
-}
+  let onMessage = waitForMessage(hud, "fooBazBaz is not defined");
+  BrowserTestUtils.synthesizeMouseAtCenter("button", {}, gBrowser.selectedBrowser);
+  await onMessage;
+
+  ok(true, "Received the expected error message");
+});