Bug 1421926 - (experiment) cache l10n in transferred size column draft
authorFred Lin <gasolin@gmail.com>
Fri, 01 Dec 2017 10:08:43 +0800
changeset 707335 55d8e12470dfad6b9b9f9da9a6ea9d0a6a29dc07
parent 707249 f2cf6d1473808039be5ecd8727cc3791d5d7d2d4
child 742917 2febcfd8c3b28deb2ca5e27f0237bbb225be2592
push id92089
push userbmo:gasolin@mozilla.com
push dateTue, 05 Dec 2017 05:40:23 +0000
bugs1421926
milestone59.0a1
Bug 1421926 - (experiment) cache l10n in transferred size column MozReview-Commit-ID: 6wqz7x7Xos7
devtools/client/netmonitor/src/components/RequestListColumnTransferredSize.js
--- a/devtools/client/netmonitor/src/components/RequestListColumnTransferredSize.js
+++ b/devtools/client/netmonitor/src/components/RequestListColumnTransferredSize.js
@@ -7,17 +7,19 @@
 const { Component } = require("devtools/client/shared/vendor/react");
 const dom = require("devtools/client/shared/vendor/react-dom-factories");
 const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
 const { getFormattedSize } = require("../utils/format-utils");
 const { L10N } = require("../utils/l10n");
 const { propertiesEqual } = require("../utils/request-utils");
 
 const { div } = dom;
-
+const SIZE_CACHED = L10N.getStr("networkMenu.sizeCached");
+const SIZE_SERVICE_WORKER = L10N.getStr("networkMenu.sizeServiceWorker");
+const SIZE_UNAVAILABLE = L10N.getStr("networkMenu.sizeUnavailable");
 const UPDATED_TRANSFERRED_PROPS = [
   "transferredSize",
   "fromCache",
   "fromServiceWorker",
 ];
 
 class RequestListColumnTransferredSize extends Component {
   static get propTypes() {
@@ -30,23 +32,23 @@ class RequestListColumnTransferredSize e
     return !propertiesEqual(UPDATED_TRANSFERRED_PROPS, this.props.item, nextProps.item);
   }
 
   render() {
     let { fromCache, fromServiceWorker, status, transferredSize } = this.props.item;
     let text;
 
     if (fromCache || status === "304") {
-      text = L10N.getStr("networkMenu.sizeCached");
+      text = SIZE_CACHED;
     } else if (fromServiceWorker) {
-      text = L10N.getStr("networkMenu.sizeServiceWorker");
+      text = SIZE_SERVICE_WORKER;
     } else if (typeof transferredSize == "number") {
       text = getFormattedSize(transferredSize);
     } else if (transferredSize === null) {
-      text = L10N.getStr("networkMenu.sizeUnavailable");
+      text = SIZE_UNAVAILABLE;
     }
 
     return (
       div({ className: "requests-list-column requests-list-transferred", title: text },
         text
       )
     );
   }