Bug 1419538 - Marionette log entries should show object details. draft
authorHenrik Skupin <mail@hskupin.info>
Thu, 30 Nov 2017 15:09:32 +0100
changeset 705795 1be770da2a77484c539ec061ca8a00ab5fa36ad3
parent 705339 14aa1b15bb8ff0bd1489c246faea224a0e7a8c56
child 742459 76c9cd05bdc978191a5ffa1dc6c34e63c1efef40
push id91583
push userbmo:hskupin@gmail.com
push dateThu, 30 Nov 2017 17:18:46 +0000
bugs1419538
milestone59.0a1
Bug 1419538 - Marionette log entries should show object details. By missing to convert a Javascript object to a packet and serializing it, no details were printed eg for session capabilities for the call to "start_session()". MozReview-Commit-ID: HdcehGpBvdA
testing/marionette/message.js
--- a/testing/marionette/message.js
+++ b/testing/marionette/message.js
@@ -22,17 +22,18 @@ class Message {
    * @param {number} messageID
    *     Message ID unique identifying this message.
    */
   constructor(messageID) {
     this.id = assert.integer(messageID);
   }
 
   toString() {
-    return truncate`${this.toPacket()}`;
+    let content = JSON.stringify(this.toPacket());
+    return truncate`${content}`;
   }
 
   /**
    * Converts a data packet into a {@link Command} or {@link Response}.
    *
    * @param {Array.<number, number, ?, ?>} data
    *     A four element array where the elements, in sequence, signifies
    *     message type, message ID, method name or error, and parameters