Bug 1419819 - Remove html|button padding rule from common stylesheet. r=jaws draft
authorScott Wu <scottcwwu@gmail.com>
Thu, 30 Nov 2017 11:24:44 +0800
changeset 705553 02eb4144a1fb66e8800fadc7ac6b3486c99c557b
parent 705442 38f49346a200cc25492236c7b3c536fc835fe031
child 742400 08a44e1f73c73b1402cfbf3b5d22a7381f36eb45
push id91517
push userbmo:scwwu@mozilla.com
push dateThu, 30 Nov 2017 10:34:18 +0000
reviewersjaws
bugs1419819, 1413162
milestone59.0a1
Bug 1419819 - Remove html|button padding rule from common stylesheet. r=jaws Bug 1413162 added the html|button padding rule intended to normalize the way buttons are styled in preferences, but ended up causing problems for buttons outside of preferences, especially because !important keyword is used. This bug reverts that change. MozReview-Commit-ID: FFQt2k6mCHE
browser/extensions/formautofill/content/manageDialog.css
browser/extensions/formautofill/skin/shared/editDialog.css
toolkit/themes/shared/in-content/common.inc.css
--- a/browser/extensions/formautofill/content/manageDialog.css
+++ b/browser/extensions/formautofill/content/manageDialog.css
@@ -1,16 +1,21 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 div {
   display: flex;
 }
 
+button {
+  padding-right: 10px;
+  padding-left: 10px;
+}
+
 fieldset {
   margin: 0;
   padding: 0;
   border: none;
 }
 
 fieldset > legend {
   box-sizing: border-box;
--- a/browser/extensions/formautofill/skin/shared/editDialog.css
+++ b/browser/extensions/formautofill/skin/shared/editDialog.css
@@ -32,16 +32,21 @@ div > span {
 option {
   padding: 0.3em 0.5em;
 }
 
 textarea {
   resize: none;
 }
 
+button {
+  padding-right: 10px;
+  padding-left: 10px;
+}
+
 input,
 select {
   box-sizing: border-box;
   flex: 1 0 auto;
 }
 
 #controls-container {
   flex: 0 1 100%;
--- a/toolkit/themes/shared/in-content/common.inc.css
+++ b/toolkit/themes/shared/in-content/common.inc.css
@@ -259,17 +259,16 @@ xul|button.primary:not([disabled="true"]
   background-color: var(--in-content-primary-button-background-active);
 }
 
 xul|colorpicker[type="button"] {
   padding: 6px;
   width: 50px;
 }
 
-html|button,
 xul|button > xul|*.button-box,
 xul|menulist > xul|*.menulist-label-box {
   padding-right: 10px !important;
   padding-left: 10px !important;
 }
 
 xul|menulist > xul|*.menulist-label-box > xul|*.menulist-icon[src] {
   margin-inline-end: 5px;