Bug 1420357 - The default value of positionAlign is "auto". r=rillian draft
authorbechen@mozilla.com <bechen@mozilla.com>
Thu, 30 Nov 2017 11:17:28 +0800
changeset 705459 56b6cd5befbb7c76384290f2f0d8915231ee27f6
parent 704986 ab6066f260abac25d71a1c35511c5389444e000a
child 706069 583017ebda0aecf396c71bb6b3bdd79344cf4c61
child 706070 189e0760da67d7c6f7407b770d5d873822bed989
child 706071 4f5af2e0f2185c9237e0fafb412bb02b1831c529
child 706726 ccd64c67d9bc278c79726e4ac7a8d9fe81f2a8d5
child 706727 ea80a61cc078ef4f404f76451c35cf039fa39df4
child 707378 cf297ecfb446f398a2d09291894ce3f0f06a5d34
child 708752 055597c066a86aa0f9ecb106080026fd81caec35
child 708776 31de6da08d022404a052335cb0900dd6e5e24dd5
push id91472
push userbmo:bechen@mozilla.com
push dateThu, 30 Nov 2017 03:18:26 +0000
reviewersrillian
bugs1420357
milestone59.0a1
Bug 1420357 - The default value of positionAlign is "auto". r=rillian MozReview-Commit-ID: KkRzI3B5mfZ
dom/media/test/test_texttrackcue.html
dom/media/test/test_webvtt_positionalign.html
dom/media/test/vttPositionAlign.vtt
--- a/dom/media/test/test_texttrackcue.html
+++ b/dom/media/test/test_texttrackcue.html
@@ -139,17 +139,17 @@ SpecialPowers.pushPrefEnv({"set": [["med
       cue.lineAlign = "center";
       is(cue.lineAlign, "center", "Cue's line align should be center.");
       cue.lineAlign = "START";
       is(cue.lineAlign, "center", "Cue's line align should be center.");
       cue.lineAlign = "end";
       is(cue.lineAlign, "end", "Cue's line align should be end.");
 
       // Check that cue position align works properly
-      is(cue.positionAlign, "center", "Cue's default position alignment should be center.");
+      is(cue.positionAlign, "auto", "Cue's default position alignment should be auto.");
 
       cue.positionAlign = "line-left";
       is(cue.positionAlign, "line-left", "Cue's position align should be line-left.");
       cue.positionAlign = "auto";
       is(cue.positionAlign, "auto", "Cue's position align should be auto.");
       cue.positionAlign = "line-right";
       is(cue.positionAlign, "line-right", "Cue's position align should be line-right.");
 
--- a/dom/media/test/test_webvtt_positionalign.html
+++ b/dom/media/test/test_webvtt_positionalign.html
@@ -38,17 +38,17 @@ function runTest() {
   isnot(window.TextTrackCue, undefined, "TextTrackCue should be defined.");
   isnot(window.VTTCue, undefined, "VTTCue should be defined.");
 
   info("--- check the type of first parsed cue ---");
   ok(cues[0] instanceof TextTrackCue, "Cue should be an instanceof TextTrackCue.");
   ok(cues[0] instanceof VTTCue, "Cue should be an instanceof VTTCue.");
 
   info("--- check the cue's position alignment ---");
-  is(cues[0].positionAlign, "center",     cues[0].text);
+  is(cues[0].positionAlign, "auto",     cues[0].text);
   is(cues[1].positionAlign, "line-left",  cues[1].text);
   is(cues[2].positionAlign, "center",     cues[2].text);
   is(cues[3].positionAlign, "line-right", cues[3].text);
   is(cues[4].positionAlign, "auto",       cues[4].text);
 
   info("--- check the cue's computed position alignment ---");
   // The "computedPositionAlign" is the chrome-only attributes, we need to get
   // the chrome privilege for cues.
--- a/dom/media/test/vttPositionAlign.vtt
+++ b/dom/media/test/vttPositionAlign.vtt
@@ -1,12 +1,12 @@
 WEBVTT
 
 00:00.000 --> 00:00.500
-Cue 0 : PositionAlign should be "center".
+Cue 0 : PositionAlign should be "auto".
 
 00:00.700 --> 00:00.800 position:50%,line-left
 Cue 1 : PositionAlign should be "line-left".
 
 00:00.700 --> 00:00.800 position:50%,center
 Cue 2 : PositionAlign should be "center".
 
 00:00.700 --> 00:00.800 position:50%,line-right